Repository navigation
Feature / Arpeggiator "Note probability" - #2978
Merged
stellar-aria merged 5 commits intoNov 25, 2024
Merged
Conversation
Contributor
Collaborator
Author
|
This one is ready for review |
stellar-aria
requested changes
Nov 25, 2024
Collaborator
Author
|
@stellar-aria I made some changes and answered your questions. Let me know if any changes needed |
stellar-aria
approved these changes
Nov 25, 2024
stellar-aria
added this pull request to the merge queue
Nov 25, 2024
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 12, 2026
* Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
* Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
* Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
* Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
* Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
* Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
* Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
* Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
* Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
* Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
* Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
* Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
* Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
* Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) (SynthstromAudible#2985) * Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it * refactor * Trigger Build Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990) * Added all parameters, menus, strings and docs * Refactor and add midi submenus * Spread lock parameter * fix * read and write locked spread values * Refactor * deal with indexes increasing * remove unneeded imports * wip * done! * docs * Docs * Docs * Modulate values in different ways and adjusted docs * format * fixed gate * fix bug * fix docs * docs * Update docs Feature / Arpeggiator "Note probability" (SynthstromAudible#2978) * Note probability * Changed name of parameter for 7SEG * Update docs * feedback * Feedback Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988) Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021) * Keep droning if arp is ON * format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds note probability to the arpeggiated notes (applied at the end of the chain, after rhythm and sequence length have been evaluated).
I had this PR in the past but was not happy with it because if first was not played, the sound entered an idle state and no more notes were played. I solved it now (you need to call reassessRenderSkippingStatus so it evaluates the note anyways)