feature: Piano Keyboard - #2983
Conversation
stellar-aria
left a comment
There was a problem hiding this comment.
LGTM, but I'd like a second opinion.
|
Actually, on second look I think this is good to go. Thank you so much for doing this! (And thank you for writing such clean, documented code!) |
|
Thank you, for the review, @stellar-aria ! |
|
There's some compile issues that will prevent this from merging:
Can we also document this feature please: Community Features: add it after 4.4.1.7 https://github.com/SynthstromAudible/DelugeFirmware/blob/community/docs/community_features.md#4417---display-chord-library-keyboard-layout Change Log: add it under Keyboard View |
|
Thanks @seangoodvibes for finding! I fixed the json and added documentation. Please let me know if anything else is needed.! 🙏 |
Thanks! Just a couple more things |
|
Thanks, @seangoodvibes for guiding me! |
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
* feature: piano keyboard * fix seven_segment.json, add documentation * fix formating * add piano keyb layout to the doc menu --------- Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc>
This PR implements a new Piano Keyboard in Deluge.
Demo
https://www.youtube.com/watch?v=sAme2Ztx4FE
Features
Description
This is the classic piano keyboard layout for Deluge.
Now you can play your favourite chords and triads in Deluge in the usual way.
The white keys are on the first row, and the black ones are on the second.
This keyboard is duplicated on the screen. And you can move octaves to the right or up.
You can also play with both hands, increasing octaves with one hand or the other.
So, 5 octaves on one screen. But you can also scroll this keyboard vertically to increase octaves to the highest or decrease to the lowest.
You can also turn on the scale. And all the notes in this scale will be displayed brighter than the notes outside the scale. Of course, you can change the scale to minor or any other, and the keys will change accordingly.
The same thing with the root note. It is displayed brighter than the others. You can also change the root note.
And of course all the notes you play are also highlighted.
But that's not all. You can switch the keyboard to start on a different note than C. This is done by using the horizontal scroll. This way you can set the keyboard to start on the note you want.
Last but not least, this keyboard highlights incoming MIDI notes.
This feature was requested in #55 but not wasn't finished. I hope you will like it now.
Thanks!