Skip to content

Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) #2985

Merged
m-m-adams merged 7 commits into
SynthstromAudible:communityfrom
soymonitus:monitus/arp_chord_for_kits
Dec 5, 2024
Merged

Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows) #2985
m-m-adams merged 7 commits into
SynthstromAudible:communityfrom
soymonitus:monitus/arp_chord_for_kits

Conversation

@soymonitus

Copy link
Copy Markdown
Collaborator

This feature allows you to chose an "emulated" chord for the arpeggiator in a kit row so you can use the Note Mode of the arpeggiator also on note rows. Before, it was useless to have a Note Mode as you could only have one note pressed, but with the new "Chord Type" parameter it is like if you were pressing a chord for the arpeggiator

@github-actions

github-actions Bot commented Nov 28, 2024

Copy link
Copy Markdown
Contributor

Test Results

106 tests  ±0   106 ✅ ±0   0s ⏱️ -1s
 16 suites ±0     0 💤 ±0 
 16 files   ±0     0 ❌ ±0 

Results for commit cf59afc. ± Comparison against base commit 28959e8.

♻️ This comment has been updated with latest results.

@soymonitus

Copy link
Copy Markdown
Collaborator Author

ready for review! @stellar-aria ? @seangoodvibes ? :)

@m-m-adams m-m-adams left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general!

Comment thread src/deluge/gui/ui/keyboard/layout/column_controls.cpp
Comment thread src/deluge/gui/ui/keyboard/layout/column_controls.cpp
@soymonitus

Copy link
Copy Markdown
Collaborator Author

@m-m-adams I refactored some small things

@m-m-adams m-m-adams added this pull request to the merge queue Dec 5, 2024
Merged via the queue into SynthstromAudible:community with commit 62fc344 Dec 5, 2024
@soymonitus soymonitus deleted the monitus/arp_chord_for_kits branch December 6, 2024 07:46
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 12, 2026
… Mode" to kit rows) (SynthstromAudible#2985)

* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
… Mode" to kit rows) (SynthstromAudible#2985)

* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
… Mode" to kit rows) (SynthstromAudible#2985)

* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
… Mode" to kit rows) (SynthstromAudible#2985)

* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
… Mode" to kit rows) (SynthstromAudible#2985)

* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
… Mode" to kit rows) (SynthstromAudible#2985)

* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
… Mode" to kit rows) (SynthstromAudible#2985)

* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
… Mode" to kit rows) (SynthstromAudible#2985)

* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
… Mode" to kit rows) (SynthstromAudible#2985)

* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
… Mode" to kit rows) (SynthstromAudible#2985)

* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
… Mode" to kit rows) (SynthstromAudible#2985)

* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
… Mode" to kit rows) (SynthstromAudible#2985)

* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
… Mode" to kit rows) (SynthstromAudible#2985)

* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
… Mode" to kit rows) (SynthstromAudible#2985)

* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 15, 2026
Feature / Arpeggiator "Chord Type" for Kit Rows (and added back "Note Mode" to kit rows)  (SynthstromAudible#2985)
* Implement Chord selector for arpeggiator of kit rows, so you can now use NoteMode on it

* refactor

* Trigger Build

Feature / Arpeggiator Spread (Lock, Velocity, Gate, Octave) (SynthstromAudible#2990)

* Added all parameters, menus, strings and docs

* Refactor and add midi submenus

* Spread lock parameter

* fix

* read and write locked spread values

* Refactor

* deal with indexes increasing

* remove unneeded imports

* wip

* done!

* docs

* Docs

* Docs

* Modulate values in different ways and adjusted docs

* format

* fixed gate

* fix bug

* fix docs

* docs

* Update docs

Feature / Arpeggiator "Note probability" (SynthstromAudible#2978)

* Note probability

* Changed name of parameter for 7SEG

* Update docs

* feedback

* Feedback

Fix default value for midi arpeggiator note probability (set to 50) (SynthstromAudible#2988)

Fix / allow notes to drone when arp is ON even if they use samples in CUT mode (SynthstromAudible#3021)

* Keep droning if arp is ON

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants