Resolved Audition Pad Illumination Issue on Drum Keyboard Screen#317
Merged
jamiefaye merged 1 commit intoAug 7, 2023
Merged
Conversation
In the Drum Keyboard screen, we have fixed the issue where audition pads would remain illuminated after pressing pads 9 to 16 and then returning to the clip view.
Collaborator
|
Very nice catch! I will check your fix as soon as possible :) I have overlooked it because it didn't happen for my default kit with <= 8 elements |
Collaborator
|
Also a good place to thank you for implementing the foundation of the drum keyboard!😀 and also the very handy video explaining the behavior! |
stellar-aria
approved these changes
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Drum Keyboard screen, I have fixed the issue where audition pads would remain illuminated after pressing pads 9 to 16 and then returning to the clip view.
https://youtu.be/TkzCt-VDFt4