add section number to clip names, copy clip names along with clips#3195
Merged
stellar-aria merged 2 commits intoJan 2, 2025
Conversation
- if clip has no name, display "Section: <section num>" - if clip has a name, display "<section num>: <clip name>"
- append a number to the clip name if necessary to avoid duplicates on the same output; if the name already ends with a number, the existing number is incremented instead
Contributor
stellar-aria
approved these changes
Jan 2, 2025
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 16, 2026
…ynthstromAudible#3195) * use section numbers with clip names - if clip has no name, display "Section: <section num>" - if clip has a name, display "<section num>: <clip name>" * copy clip names when duplicating clips - append a number to the clip name if necessary to avoid duplicates on the same output; if the name already ends with a number, the existing number is incremented instead
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 16, 2026
…clips (SynthstromAudible#3195)" This reverts commit 81d3ca8.
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 16, 2026
…ynthstromAudible#3195) * use section numbers with clip names - if clip has no name, display "Section: <section num>" - if clip has a name, display "<section num>: <clip name>" * copy clip names when duplicating clips - append a number to the clip name if necessary to avoid duplicates on the same output; if the name already ends with a number, the existing number is incremented instead
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 16, 2026
refactor rename-uis, allow naming CV clips as well (SynthstromAudible#3183) * refactor rename-uis, allow naming CV clips as well - allow deleting names (by replacing them with empty) for all but drums - consolidate shared code in RenameUI class: subclasses implement only a couple of methods to specialize their behaviour - ad-hoc dispatch in sound_editor.cpp replaced with normal shortcut machinery - shrinks the binary by just a hair, but *shrinks*, not grows! * fix initialization of RenameUIs --------- Co-authored-by: Sapphire Koser <srkoser+GitHub@gmail.com> Fix rename-UIs PR (SynthstromAudible#3218) * Revert "refactor rename-uis, allow naming CV clips as well (SynthstromAudible#3183)" This reverts commit 0d55ca5. * Bugfix for rename-UIs PR add section number to clip names, copy clip names along with clips (SynthstromAudible#3195) * use section numbers with clip names - if clip has no name, display "Section: <section num>" - if clip has a name, display "<section num>: <clip name>" * copy clip names when duplicating clips - append a number to the clip name if necessary to avoid duplicates on the same output; if the name already ends with a number, the existing number is incremented instead Co-Authored-By: Nikodemus Siivola <nikodemus@random-state.net> Co-Authored-By: Katherine Whitlock <122173759+stellar-aria@users.noreply.github.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 16, 2026
…ynthstromAudible#3195) * use section numbers with clip names - if clip has no name, display "Section: <section num>" - if clip has a name, display "<section num>: <clip name>" * copy clip names when duplicating clips - append a number to the clip name if necessary to avoid duplicates on the same output; if the name already ends with a number, the existing number is incremented instead Revert "add section number to clip names, copy clip names along with clips (SynthstromAudible#3195)" This reverts commit 81d3ca8.
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 16, 2026
refactor rename-uis, allow naming CV clips as well (SynthstromAudible#3183) * refactor rename-uis, allow naming CV clips as well - allow deleting names (by replacing them with empty) for all but drums - consolidate shared code in RenameUI class: subclasses implement only a couple of methods to specialize their behaviour - ad-hoc dispatch in sound_editor.cpp replaced with normal shortcut machinery - shrinks the binary by just a hair, but *shrinks*, not grows! * fix initialization of RenameUIs --------- Co-authored-by: Sapphire Koser <srkoser+GitHub@gmail.com> Fix rename-UIs PR (SynthstromAudible#3218) * Revert "refactor rename-uis, allow naming CV clips as well (SynthstromAudible#3183)" This reverts commit 0d55ca5. * Bugfix for rename-UIs PR add section number to clip names, copy clip names along with clips (SynthstromAudible#3195) * use section numbers with clip names - if clip has no name, display "Section: <section num>" - if clip has a name, display "<section num>: <clip name>" * copy clip names when duplicating clips - append a number to the clip name if necessary to avoid duplicates on the same output; if the name already ends with a number, the existing number is incremented instead Co-Authored-By: Nikodemus Siivola <nikodemus@random-state.net> Co-Authored-By: Katherine Whitlock <122173759+stellar-aria@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.