Skip to content

Added 2 more envelopes#3279

Merged
seangoodvibes merged 2 commits into
SynthstromAudible:communityfrom
soymonitus:monitus/more_envelopes
Jan 13, 2025
Merged

Added 2 more envelopes#3279
seangoodvibes merged 2 commits into
SynthstromAudible:communityfrom
soymonitus:monitus/more_envelopes

Conversation

@soymonitus

Copy link
Copy Markdown
Collaborator

Full credit to @nikodemus

This PR adds two more envelopes, which can be accessed from the sound editor menu.

In a future PR (Layered Menus), they could be made accessible from double clicking the ADSR shortcuts on the grid, but this is not in scope in this PR

@github-actions

github-actions Bot commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

Test Results

106 tests  ±0   106 ✅ ±0   0s ⏱️ ±0s
 16 suites ±0     0 💤 ±0 
 16 files   ±0     0 ❌ ±0 

Results for commit e74d4e1. ± Comparison against base commit 4f43b9f.

♻️ This comment has been updated with latest results.

@nikodemus

Copy link
Copy Markdown
Collaborator

I would appreciate if this was rebased to preserve my authorship of the envelope commit. (Amending with --author "New Author Name <email@address.example>" does it.)

Not a huge deal, but, eh.

nikodemus and others added 2 commits January 13, 2025 02:36
Co-authored-by: Raúl Muñoz <raul@mothership.com>
@soymonitus

Copy link
Copy Markdown
Collaborator Author

I think this PR needs to be merged without squashing commits, so authorship of "Added 2 envelopes" by Nikodemus is preserved?

@seangoodvibes seangoodvibes added this pull request to the merge queue Jan 13, 2025
Merged via the queue into SynthstromAudible:community with commit 9b843d9 Jan 13, 2025
@soymonitus soymonitus deleted the monitus/more_envelopes branch January 13, 2025 16:51
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026
* Added 2 envelopes

Co-authored-by: Raúl Muñoz <raul@mothership.com>

* Correct PR number

---------

Co-authored-by: Nikodemus Siivola <nikodemus@random-state.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants