Feature / Arpeggiator new Walk & Pattern note mode by soymonitus · Pull Request #3285 · SynthstromAudible/DelugeFirmware

soymonitus · 2025-01-15T19:09:01Z

Added two new note modes: Walk and Pattern
As in the docs:
- Walk1 (WALK1) is the "slow" walk and next note is selected this way:
- 30% of probability to walk the sequence a step in reverse.
- 30% of probability to just repeat the same step of the sequence.
- 40% of probability to walk the sequence a step forward (as normal).
- Walk2 (WALK2) is the "normal" walk and next note is selected this way:
- 25% of probability to walk the sequence a step in reverse.
- 25% of probability to just repeat the same step of the sequence.
- 50% of probability to walk the sequence a step forward (as normal).
- Walk3 (WALK3) is the "fast" walk and next note is selected this way:
- 20% of probability to walk the sequence a step in reverse.
- 20% of probability to just repeat the same step of the sequence.
- 60% of probability to walk the sequence a step forward (as normal).
- Pattern (PATT) each time you select this Note Mode on the menu it will generate a new pattern for you.
The pattern is like if you had selected Played Order and the Deluge had decided the order for you.
Tip: as this mode is the last selectable one, if you try to scroll past the end of the menu, the Deluge
will interpret it as a re-selection of the Pattern mode and so it will generate a new pattern for you.
Note: the pattern is saved to the song so you can recreate it after reloading the song.
Note: this mode is not available for Kit Rows.

This PR also does some refactoring and cleanup of the arpeggiator code, removing dead code that was doing nothing, and repacking duplicated code into common functions.

The tests for how long it takes a sequence of notes to cycle:

I did several test passes with a 4-note chord on 1-bar, with an arpeggio of 4 octaves (16th notes) (With notemode=up it takes 1 bar to reach the highest note)

It took ~10 bars for the Walk1 (slow) to reach the highest note
It took ~6 bars for the Walk2 (normal) to reach the highest note
It took ~3 bars for the Walk3 (fast) to reach the highest note

Programmed like the Arturia MiniFreak synth “Walk” mode

github-actions · 2025-01-15T19:10:38Z

Test Results

107 tests ±0 107 ✅ ±0 0s ⏱️ -1s
16 suites ±0 0 💤 ±0
16 files ±0 0 ❌ ±0

Results for commit 7d2e94c. ± Comparison against base commit c91a932.

♻️ This comment has been updated with latest results.

soymonitus · 2025-01-16T22:35:34Z

This is ready for review!

soymonitus · 2025-01-18T11:08:05Z

Ok, after receiving some feedback in Discord, I added 3 different walk modes, with different probabilities so anyone can choose the desired "feel" depending on the context.

This is now ready for review

…#3285) * Arpeggiator Walk mode (in Randomizer menu) Programmed like the Arturia MiniFreak synth “Walk” mode * Format * Walk and Pattern note modes * docs and refactor * docs * fix * format docs * Added WALK1, WALK2 and WALK3 to have different speeds of walking * Format * fix * adjustment * Adjust probabilities so they are better balanced * Format * Fix saving of chord simulator parameter

Feature / Arpeggiator 3.0 (SynthstromAudible#3079) * Feature / Arp Root Chance parameter * Rename Bass Focus to Bass Chance * Fix compile * wip * refactor * wip * wip * wip * fix compile * fix * Fix! * renaming * labels * dic * fix * Enable arpeggiator on MIDI and CV drums * fix compile * Change menu order. Step repeat disabled for Gate drum * docs * docs * fix * fixes * Use Velocity Spread for both normal and arp notes * Velocity is bipolar * Make Spread params use relative percentages instead of absolute values for a smoother feel * Using triangle * Updated docs * docs * Implemented Chord Probability for synths and non-mpe midi clips * Format * Fix mpeValuesSum calculation * Refactor * wip * format * fix warning * Remove comment * Refactoring * compile * Update changelog * docs * Remove dead code * Refactoring * Remove duplicated code * Fixed bug with Gate Spread * Refactor * Refactor 2 Feature / Arpeggiator new Walk & Pattern note mode (SynthstromAudible#3285) * Arpeggiator Walk mode (in Randomizer menu) Programmed like the Arturia MiniFreak synth “Walk” mode * Format * Walk and Pattern note modes * docs and refactor * docs * fix * format docs * Added WALK1, WALK2 and WALK3 to have different speeds of walking * Format * fix * adjustment * Adjust probabilities so they are better balanced * Format * Fix saving of chord simulator parameter Horizontal menus for arpeggiator's randomizer submenu (SynthstromAudible#3238) * Prefer the 7SEG string for the horizontal menu titles * Horizontal menus for arpeggiator’s randomizer, and fixed documentation * format * Change docs * Format * Revert setting 7Seg name as the default name for horizontal menus * Change order of LFO params to match grid shortcuts * Put arp params in groups and add them to the grid shortcuts as horizontal menus * Update menu hierarchies * Fixed menus for all types: sound, midi, cv, drums * format * Format * Added Randomizer to “Mode” shortcut, visible when horizontal menus are on * format audio player: fix shortcuts (SynthstromAudible#3230) These got offset, re-adding the duplicate row (so sample1/sample2 columns behave the same) should fix the issue.

Arpeggiator Walk mode (in Randomizer menu)

69c933a

Programmed like the Arturia MiniFreak synth “Walk” mode

soymonitus marked this pull request as draft January 15, 2025 19:09

soymonitus added 3 commits January 15, 2025 20:15

Format

b0ddcf8

Walk and Pattern note modes

0cace63

Merge branch 'community' into monitus/arp_walk

cebad82

soymonitus changed the title ~~Feature / Arpeggiator Walk mode (in Randomizer menu)~~ Feature / Arpeggiator new Walk & Pattern note mode Jan 16, 2025

soymonitus marked this pull request as ready for review January 16, 2025 22:04

soymonitus added 3 commits January 16, 2025 23:25

docs and refactor

c408b82

docs

c8b6dba

fix

c94ee78

soymonitus added 7 commits January 17, 2025 10:38

format docs

585133d

Added WALK1, WALK2 and WALK3 to have different speeds of walking

1b32cb2

Format

f68bd57

fix

b8e4847

adjustment

efd3635

Adjust probabilities so they are better balanced

8bf098c

Format

01dd7a2

soymonitus added 4 commits January 19, 2025 10:58

Merge branch 'community' into monitus/arp_walk

86cabf4

Merge branch 'community' into monitus/arp_walk

6f8cb2d

Merge branch 'community' into monitus/arp_walk

90598f8

Fix saving of chord simulator parameter

7d2e94c

m-m-adams approved these changes Jan 25, 2025

View reviewed changes

m-m-adams added this pull request to the merge queue Jan 25, 2025

Merged via the queue into SynthstromAudible:community with commit 147ba6c Jan 25, 2025

soymonitus deleted the monitus/arp_walk branch January 25, 2025 23:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Feature / Arpeggiator new Walk & Pattern note mode#3285

Feature / Arpeggiator new Walk & Pattern note mode#3285
m-m-adams merged 18 commits into
SynthstromAudible:communityfrom
soymonitus:monitus/arp_walk

soymonitus commented Jan 15, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 15, 2025 •

edited

Loading

Uh oh!

soymonitus commented Jan 16, 2025

Uh oh!

soymonitus commented Jan 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

soymonitus commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

soymonitus commented Jan 16, 2025

Uh oh!

soymonitus commented Jan 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

soymonitus commented Jan 15, 2025 •

edited

Loading

github-actions Bot commented Jan 15, 2025 •

edited

Loading