LFO 3 & 4 by soymonitus · Pull Request #3332 · SynthstromAudible/DelugeFirmware

soymonitus · 2025-02-04T12:43:18Z

No description provided.

# Conflicts: # src/deluge/gui/views/automation_view.cpp

github-actions · 2025-02-04T12:45:11Z

Test Results

107 tests ±0 107 ✅ ±0 1s ⏱️ -1s
16 suites ±0 0 💤 ±0
16 files ±0 0 ❌ ±0

Results for commit 130574c. ± Comparison against base commit d08a56f.

♻️ This comment has been updated with latest results.

seangoodvibes · 2025-02-04T13:01:16Z

 	uint32_t sourcesChanged; // Applies from first source up to FIRST_UNCHANGEABLE_SOURCE

 	LFO globalLFO;
+	LFO globalLFO2;


You'll have to really test to confirm adding a line here doesn't reintroduce any sound bugs as per the comment below.

Tested removing the padding and the release issue re-appears, so the padding is still needed. I see no other appreciable changes in sound, at least with the bass sound mentioned in the issue ticket.

soymonitus · 2025-02-05T08:03:19Z

@seangoodvibes Ready for review

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

wip

30cc851

# Conflicts: # src/deluge/gui/views/automation_view.cpp

soymonitus marked this pull request as draft February 4, 2025 12:43

seangoodvibes reviewed Feb 4, 2025

View reviewed changes

soymonitus added 2 commits February 4, 2025 16:13

wip

3cbfe43

midi follow

6e1d436

soymonitus changed the title ~~[Draft] LFO 3 & 4~~ LFO 3 & 4 Feb 4, 2025

soymonitus marked this pull request as ready for review February 4, 2025 15:21

Merge branch 'community' into monitus/lfos

82758e2

soymonitus added 3 commits February 7, 2025 09:51

Take opportunity to add missing new enevelopes code to Sound class

a4e87dd

Merge branch 'community' into monitus/lfos

af415b7

Merge branch 'community' into monitus/lfos

130574c

m-m-adams approved these changes Feb 8, 2025

View reviewed changes

m-m-adams added this pull request to the merge queue Feb 8, 2025

Merged via the queue into SynthstromAudible:community with commit 44d8e60 Feb 8, 2025

soymonitus deleted the monitus/lfos branch February 8, 2025 19:00

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026

LFO 3 & 4 (SynthstromAudible#3332)

3b3e896

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026

LFO 3 & 4 (SynthstromAudible#3332)

bb22a11

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026

LFO 3 & 4 (SynthstromAudible#3332)

9819545

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026

LFO 3 & 4 (SynthstromAudible#3332)

310dbe8

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026

LFO 3 & 4 (SynthstromAudible#3332)

6fac73f

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026

LFO 3 & 4 (SynthstromAudible#3332)

dfc0a6e

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026

LFO 3 & 4 (SynthstromAudible#3332)

867085c

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026

LFO 3 & 4 (SynthstromAudible#3332)

ace1cb2

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026

LFO 3 & 4 (SynthstromAudible#3332)

b4cf6cb

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026

LFO 3 & 4 (SynthstromAudible#3332)

8b6de4c

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 17, 2026

LFO 3 & 4 (SynthstromAudible#3332)

152e74d

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026

LFO 3 & 4 (SynthstromAudible#3332)

bb227d3

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026

LFO 3 & 4 (SynthstromAudible#3332)

152c18a

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026

LFO 3 & 4 (SynthstromAudible#3332)

8374380

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026

LFO 3 & 4 (SynthstromAudible#3332)

e29d57b

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026

LFO 3 & 4 (SynthstromAudible#3332)

2814b04

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026

LFO 3 & 4 (SynthstromAudible#3332)

ae7e1b9

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026

LFO 3 & 4 (SynthstromAudible#3332)

4b6b5a3

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 18, 2026

LFO 3 & 4 (SynthstromAudible#3332)

d104b8d

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

LFO 3 & 4 (SynthstromAudible#3332)

3e0e7f7

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

LFO 3 & 4 (SynthstromAudible#3332)

a2bcedc

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

LFO 3 & 4 (SynthstromAudible#3332)

fcc48c2

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

LFO 3 & 4 (SynthstromAudible#3332)

f9e1719

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

LFO 3 & 4 (SynthstromAudible#3332)

15928d1

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

LFO 3 & 4 (SynthstromAudible#3332)

3b031a2

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

LFO 3 & 4 (SynthstromAudible#3332)

3159490

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

LFO 3 & 4 (SynthstromAudible#3332)

4200475

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

LFO 3 & 4 (SynthstromAudible#3332)

8e267af

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

LFO 3 & 4 (SynthstromAudible#3332)

4a0c41b

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026

LFO 3 & 4 (SynthstromAudible#3332)

2015b58

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026

LFO 3 & 4 (SynthstromAudible#3332)

2479e20

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026

LFO 3 & 4 (SynthstromAudible#3332)

868b4a3

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026

LFO 3 & 4 (SynthstromAudible#3332)

dd22174

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026

LFO 3 & 4 (SynthstromAudible#3332)

b7a742b

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026

LFO 3 & 4 (SynthstromAudible#3332)

fde9737

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026

LFO 3 & 4 (SynthstromAudible#3332)

f90cb1d

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026

LFO 3 & 4 (SynthstromAudible#3332)

c843ec4

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026

LFO 3 & 4 (SynthstromAudible#3332)

534f26b

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026

LFO 3 & 4 (SynthstromAudible#3332)

21391a0

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026

LFO 3 & 4 (SynthstromAudible#3332)

009ac89

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026

LFO 3 & 4 (SynthstromAudible#3332)

be8e92c

* wip * wip * midi follow * Take opportunity to add missing new enevelopes code to Sound class

Navigation Menu

Repository navigation

LFO 3 & 4 - #3332

LFO 3 & 4#3332
m-m-adams merged 7 commits into
SynthstromAudible:communityfrom
soymonitus:monitus/lfos

soymonitus commented Feb 4, 2025

Uh oh!

github-actions Bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

seangoodvibes Feb 4, 2025

Uh oh!

soymonitus Feb 5, 2025

Uh oh!

soymonitus commented Feb 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

soymonitus commented Feb 4, 2025

Uh oh!

github-actions Bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

seangoodvibes Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

soymonitus Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

soymonitus commented Feb 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Feb 4, 2025 •

edited

Loading