Feature / Kit Arpeggiator by soymonitus · Pull Request #3388 · SynthstromAudible/DelugeFirmware

soymonitus · 2025-02-16T08:17:24Z

Add an arpeggiator menu to the Kit affect-entire menu. This allows the user to engage an arpeggiator layer on top of the kit rows, which will control which rows receive noteOns and noteOffs. That means that the kit rows can have their own arpeggiators also enabled, which allows for unlimited possible pattern combinations.

If kit rows have a sample with sampleMode = ONCE, they will be automatically ignored from kit arpeggiator. For them to be eligible to participate in kit arpeggiator, they new to allow to input note tails in the sequencer, that is, the row is a synth or is a sample with sampleMode = CUT or LOOP.

Every kit row now has an option "Include in kit arpeggiator" inside the Arpeggiator menu, to allow them to opt-out from kit arp.

github-actions · 2025-02-16T08:19:07Z

Test Results

111 tests ±0 111 ✅ ±0 0s ⏱️ ±0s
17 suites ±0 0 💤 ±0
17 files ±0 0 ❌ ±0

Results for commit 27effb3. ± Comparison against base commit 3fc67b1.

♻️ This comment has been updated with latest results.

soymonitus · 2025-02-16T08:47:11Z

Ready for review!!

# Conflicts: # docs/community_features.md

# Conflicts: # src/deluge/gui/views/automation_view.cpp

soymonitus

@stellar-aria @m-m-adams I added some extra comments on my own changes to help on the review process in case something is not 100% clear.

soymonitus · 2025-02-28T10:31:56Z

 	}
 };

+class ArpSoundOnlyUnpatchedParam final : public UnpatchedParam {


All the changes in the files within the menu_item/* folders are just for making the new kit arpeggiator menu items appear where they should, by mainly touching the isRelevant implementation of each

soymonitus · 2025-02-28T10:32:57Z

+#include "model/song/song.h"
+
+namespace deluge::gui::menu_item::arpeggiator {
+class IncludeInKitArp final : public Selection {


This new menu item for arpeggiator menu within kit rows is to let you decide if the note row participates in the Kit arpeggiator or is excluded and plays on its own

soymonitus · 2025-02-28T10:37:19Z

 						soundEditor.currentSource->sampleControls.pitchAndSpeedAreIndependent = false;
 					}

+					if (current_value == SampleRepeatMode::ONCE) {


Similarly to what I had to implement for kit Sound rows that now can send also MIDI notes at the same time, if we change the sample repeat mode to ONCE, then this row will now have notes with no tails, which don't send note offs in the sequencer so we must send any possible noteoff in the kit arpeggiator that corresponds to this kit row to avoid stuck notes

soymonitus · 2025-02-28T10:38:48Z


 constexpr int32_t kNumNonGlobalParamsForAutomation = 81;
-constexpr int32_t kNumGlobalParamsForAutomation = 26;
+constexpr int32_t kNumGlobalParamsForAutomation = 37;


I moved all arpeggiator params from sound-only params to global params so now apart from Sounds, also the globaleffectables like Kit can have their own arp settings.

soymonitus · 2025-02-28T10:39:27Z

+    {params::Kind::UNPATCHED_GLOBAL, params::UNPATCHED_ARP_BASS_PROBABILITY},
+    {params::Kind::UNPATCHED_GLOBAL, params::UNPATCHED_REVERSE_PROBABILITY},
+    {params::Kind::UNPATCHED_GLOBAL, params::UNPATCHED_ARP_RHYTHM},
+    {params::Kind::UNPATCHED_GLOBAL, params::UNPATCHED_ARP_SEQUENCE_LENGTH},


Kit Automation view now also exposes the arpeggiator params

soymonitus · 2025-02-28T10:44:14Z

+	if (hasAnyVoices()) {
+		noteOff(nullptr);
+	}
+	arpeggiator.reset();


All types of kit rows (gate, midi and sound) need now to carefully take care of reseting also their own arpeggiators when requested to stop all voices

soymonitus · 2025-02-28T10:45:15Z

+	void noteOnPreKitArp(ModelStackWithThreeMainThings* modelStack, Drum* drum, uint8_t velocity,
+	                     int16_t const* mpeValues, int32_t fromMIDIChannel = MIDI_CHANNEL_NONE,
+	                     uint32_t sampleSyncLength = 0, int32_t ticksLate = 0, uint32_t samplesLate = 0);
+	void noteOffPreKitArp(ModelStackWithThreeMainThings* modelStack, Drum* drum, int32_t velocity = kDefaultLiftValue);


noteOnPreKitArp and noteOffPreKitArp are now the entry points of all note events sent to the Kit clip

soymonitus · 2025-02-28T10:46:39Z

+ArpeggiatorForKit::ArpeggiatorForKit() : Arpeggiator::Arpeggiator() {
+}
+
+void ArpeggiatorForKit::removeDrumIndex(ArpeggiatorSettings* arpSettings, int32_t drumIndex) {


the ArpeggiatorForKit is basically the same implementation as the synth arpeggiator but it just needed an extra method removeDrumIndex to reorder note objects when some row gets deleted

@stellar-aria I know this method uses the "notes" OrderedResizableArray, but as it was already there in the arpeggiator code, this could be refactored to be modernized after this PR is merged, to avoid making this one bigger and more difficult to review

soymonitus · 2025-02-28T10:47:46Z

 				arpNote.noteCodeOnPostArp[n] = ARP_NOTE_NONE;
 			}
-			instruction->invertReversed = isPlayReverseForCurrentStep;
+			instruction->invertReversed =


Another feature of the Kit arpeggiator is its ability to reverse the samples (or re-reverse them if already reversed)

soymonitus · 2025-02-28T10:48:30Z

 		    [UNPATCHED_MOD_FX_FEEDBACK] = STRING_FOR_MODFX_FEEDBACK,
 		    [UNPATCHED_SIDECHAIN_SHAPE] = STRING_FOR_SIDECHAIN_SHAPE,
 		    [UNPATCHED_COMPRESSOR_THRESHOLD] = STRING_FOR_THRESHOLD,
+		    [UNPATCHED_ARP_GATE] = STRING_FOR_ARP_GATE_MENU_TITLE,


All these changes in the param class is to move the arpeggiator params from UnpatchedSound to UnpatchedGlobal

# Conflicts: # src/deluge/model/global_effectable/global_effectable.h

m-m-adams

I admittedly didn't look super closely but gonna trust you and approve

* Feature / Kit Arpeggiator * Documentation * More docs * docs * docs * docs

* Feature / Kit Arpeggiator * Documentation * More docs * docs * docs * docs Chore/Clean up kit render output SynthstromAudible#3931 Cleaned up kit::renderOutput function by refactoring kit arp code to separate functions Missing note-off for kit-arpeggiator (SynthstromAudible#3866)

Feature / Kit Arpeggiator

a01ed0f

Documentation

3608ff0

soymonitus added 9 commits February 16, 2025 09:57

More docs

df24ccf

docs

b33d5f2

docs

b076e9f

Merge branch 'community' into monitus/kit_arp

8a96473

# Conflicts: # docs/community_features.md

docs

bc73885

Merge branch 'community' into monitus/kit_arp

63bec85

# Conflicts: # src/deluge/gui/views/automation_view.cpp

Merge branch 'community' into monitus/kit_arp

fb03be0

Merge branch 'community' into monitus/kit_arp

4f573a0

Merge branch 'community' into monitus/kit_arp

88adb7c

soymonitus commented Feb 28, 2025

View reviewed changes

Merge branch 'community' into monitus/kit_arp

27effb3

# Conflicts: # src/deluge/model/global_effectable/global_effectable.h

m-m-adams approved these changes Mar 1, 2025

View reviewed changes

stellar-aria approved these changes Mar 2, 2025

View reviewed changes

stellar-aria added this pull request to the merge queue Mar 2, 2025

Merged via the queue into SynthstromAudible:community with commit b207ba8 Mar 2, 2025

soymonitus deleted the monitus/kit_arp branch March 3, 2025 18:26

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 24, 2026

Feature / Kit Arpeggiator (SynthstromAudible#3388)

99a102a

* Feature / Kit Arpeggiator * Documentation * More docs * docs * docs * docs

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 24, 2026

Feature / Kit Arpeggiator (SynthstromAudible#3388)

d6d5b91

* Feature / Kit Arpeggiator * Documentation * More docs * docs * docs * docs

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

Feature / Kit Arpeggiator (SynthstromAudible#3388)

83cf661

* Feature / Kit Arpeggiator * Documentation * More docs * docs * docs * docs

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

Feature / Kit Arpeggiator (SynthstromAudible#3388)

fcba242

* Feature / Kit Arpeggiator * Documentation * More docs * docs * docs * docs

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

Feature / Kit Arpeggiator (SynthstromAudible#3388)

940d78d

* Feature / Kit Arpeggiator * Documentation * More docs * docs * docs * docs

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

Feature / Kit Arpeggiator (SynthstromAudible#3388)

123b000

* Feature / Kit Arpeggiator * Documentation * More docs * docs * docs * docs

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

Feature / Kit Arpeggiator (SynthstromAudible#3388)

555c90e

* Feature / Kit Arpeggiator * Documentation * More docs * docs * docs * docs

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

Feature / Kit Arpeggiator (SynthstromAudible#3388)

0e63ba3

* Feature / Kit Arpeggiator * Documentation * More docs * docs * docs * docs

seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026

Feature / Kit Arpeggiator (SynthstromAudible#3388)

d5422d6

* Feature / Kit Arpeggiator * Documentation * More docs * docs * docs * docs

Uh oh!

Uh oh!

Conversation

soymonitus commented Feb 16, 2025

Uh oh!

github-actions Bot commented Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

soymonitus commented Feb 16, 2025

Uh oh!

soymonitus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soymonitus Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

m-m-adams left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Feb 16, 2025 •

edited

Loading

soymonitus Feb 28, 2025 •

edited

Loading