Feature: Patchable wavefolding distortion#349
Merged
Conversation
m-m-adams
changed the title
jamiefaye
added
the
merge conflict
m-m-adams
removed
the
merge conflict
Collaborator
Author
|
Last commit increases the max range so it should be more noticeable |
seangoodvibes
approved these changes
Aug 17, 2023
seangoodvibes
left a comment
seangoodvibes
left a comment
Collaborator
There was a problem hiding this comment.
I have reviewed the code and did not notice anything out of place. I don't understand the math but it seems good to me. In areas where the new param was added I compared the code to other params and the additions are in line.
I am ok with this addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a pre filter wavefolder, and the depth is patchable/automatable. The depth is accessible in both the menu and on the pad between saturation and LPF cutoff. The fold has no effect when set to 0 and removes itself from the signal path.
Note that it has no effect on square waves, it's best with sines and triangles