note row probability#368
Merged
jamiefaye merged 2 commits intoSynthstromAudible:communityfrom Aug 19, 2023
Merged
Conversation
seangoodvibes
approved these changes
Aug 19, 2023
Collaborator
seangoodvibes
left a comment
seangoodvibes
left a comment
There was a problem hiding this comment.
I have reviewed and test this feature and the additions to the codebase make sense and I appreciate the refactoring in instrument clip view to segregate out some of the code into separate functions (display probability, set row probability).
The feature works as I would expect and is very intuitive.
great work :) approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows probability to be set for a whole note row at a time. The action is fully undoable
In combination with the euclidean sequencing this makes it very fast to get a beat going