Creates a default setting for flats or sharps - #3794
Merged
sapphire-arches merged 14 commits intoJun 22, 2025
Merged
Conversation
This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials
Contributor
Author
|
One todo: I need to update the chord keyboard to use the new flat glyph instead of saying 7FLAT5 |
dctucker
reviewed
Jun 3, 2025
Contributor
Collaborator
|
@jkschwartz could you add documentation for this in the following pages: thanks! |
Contributor
Author
|
@seangoodvibes Added docs for community_features.md. I already added notes for CHANGELOG.mdx. I am happy to add more details if needed. |
seangoodvibes
approved these changes
Jun 22, 2025
Collaborator
|
@jkschwartz one of the test checks is failing, could you try and do the following? Thanks!
|
sapphire-arches
approved these changes
Jun 22, 2025
sapphire-arches
enabled auto-merge
June 22, 2025 23:26
sapphire-arches
added this pull request to the merge queue
Jun 22, 2025
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 26, 2026
* Creates a default setting for flats or sharps This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials * Fix code style issues with Prettier * Add flat glyph, fix typo in changelog per review * Fix code style issues with Prettier * Chord keyboards use flat glyph, updating to constant * Make chord keyboard unambiguous * Fix code style issues with Prettier * Using V with a dot for sharp character in 7SEG * Updating community features documentation * Fix code style issues with Prettier * functions.cpp now depends on flashstorage.cpp so adding mock --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a defaults > UI setting called Use Sharps This will tell the deluge to use # or b for accidentials