Load synth presets into kit rows#395
Merged
m-m-adams merged 9 commits intoAug 22, 2023
Merged
Conversation
Collaborator
Author
|
I think it's good now |
seangoodvibes
requested changes
Aug 21, 2023
seangoodvibes
left a comment
seangoodvibes
left a comment
Collaborator
There was a problem hiding this comment.
Just one minor formatting change and then you're good to go.
seangoodvibes
approved these changes
Aug 22, 2023
seangoodvibes
left a comment
seangoodvibes
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Approved!
Collaborator
|
This needs to be rolled back i think! Loading kits (LOAD + Kit) no longer works, it shows the synth selector. Loading a synth also doesn't work, the synth doesn't change. Also when holding a row in Song mode and changing its type makes the Deluge hang |
Collaborator
|
Reverted this commit to test again and confirmed everything works good without this change applied |
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Aug 22, 2023
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
* Update Stutter Rate Quantize in community_features.md * Update community_features.md * Load synth presets into kit rows (#395) Use the Sound->readFromFile method to load a synth preset into a kit row after setting up the browser for synths. Errors in param manager creation occur with repeated fast scrolling and are handled by aborting the load * Fixed Automation Editor Popup Issues when Loading/Saving (#396) * Fix Automation Editor Popup Issues Fixed issue with Parameter Name Popup hiding Load/Save UI. Also at same time removed some popup code in Sound Editor that wasn't necessary anymore * Update automation_view.md * reset loading synth to kit row * only load audio files if the param manager got created * Fill clips (#196) * Fill mode for status pads first cut * Single clip fills working and all done in Session::scheduleFillClips * ConextMenuLaunchStyle put into folders, includes fixed * Attempt to fix fill quantization time * Single clip scheduling working correctly, and more self contained. * Updated launchStyle context menu to match upstream refactor * Save/load clip launch style to/from the song file * Fill clips that are playing now insta-stop when status pad pressed. * Updated fillmode branch to match definitions_cxx.hpp * Section triggers for fill clips and enforce one clip per output * Removed some easy gotos * Fixed context menu, implemented repeat count for fill scheduling. * clang format * Docs for fill clips in community features * Tidy up * Dim pads for fills in grid mode. * Updated Community Features link to Release 1.0 branch (#398) * enable CI build on release branch (#400) * Temporarily redirect nightly builds to release branch (#404) * Temporarily redirect pages and nightly builds to release branch * Reverted page changes since they would require more repo setting changes * Updated docs for session::doLaunch * clang format * Moved fill clip strings to l10n and removed last HAVE_OLED * Renumbered features in PR order in community features doc --------- Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com> Co-authored-by: Mark Adams <52469396+m-m-adams@users.noreply.github.com> Co-authored-by: Paul Freund <freund.paul@lvl3.org> --------- Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com> Co-authored-by: Paul Freund <freund.paul@lvl3.org> Co-authored-by: Jamie Fenton <jamie@fentonia.com> Co-authored-by: 0beron <robin.fairey@gmail.com>
PaulFreund
added a commit
that referenced
this pull request
Aug 23, 2023
Update link for PR #395 in Community Features.md
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* Update Stutter Rate Quantize in community_features.md * Update community_features.md * Load synth presets into kit rows (#395) Use the Sound->readFromFile method to load a synth preset into a kit row after setting up the browser for synths. Errors in param manager creation occur with repeated fast scrolling and are handled by aborting the load * Fixed Automation Editor Popup Issues when Loading/Saving (#396) * Fix Automation Editor Popup Issues Fixed issue with Parameter Name Popup hiding Load/Save UI. Also at same time removed some popup code in Sound Editor that wasn't necessary anymore * Update automation_view.md * reset loading synth to kit row * only load audio files if the param manager got created * Update link for PR #395 in Community Features.md * Update community_features.md Just re-ordered a section * Fill clips (#196) * Fill mode for status pads first cut * Single clip fills working and all done in Session::scheduleFillClips * ConextMenuLaunchStyle put into folders, includes fixed * Attempt to fix fill quantization time * Single clip scheduling working correctly, and more self contained. * Updated launchStyle context menu to match upstream refactor * Save/load clip launch style to/from the song file * Fill clips that are playing now insta-stop when status pad pressed. * Updated fillmode branch to match definitions_cxx.hpp * Section triggers for fill clips and enforce one clip per output * Removed some easy gotos * Fixed context menu, implemented repeat count for fill scheduling. * clang format * Docs for fill clips in community features * Tidy up * Dim pads for fills in grid mode. * Updated Community Features link to Release 1.0 branch (#398) * enable CI build on release branch (#400) * Temporarily redirect nightly builds to release branch (#404) * Temporarily redirect pages and nightly builds to release branch * Reverted page changes since they would require more repo setting changes * Updated docs for session::doLaunch * clang format * Moved fill clip strings to l10n and removed last HAVE_OLED * Renumbered features in PR order in community features doc --------- Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com> Co-authored-by: Mark Adams <52469396+m-m-adams@users.noreply.github.com> Co-authored-by: Paul Freund <freund.paul@lvl3.org> * Fixed clip button blinking in Audio Clip View (#397) Leverages a function from Session View to identify the Clip Type while in Song View and using an array from Arranger view to identify the Clip Type while in Arranger View. * Fill mode fixes (#399) * Show FILL conditional value for notes set to fill mode. * Improve sync scaling button runtime setting display on OLED. * Fix some appearances of "DISABLED" in menus where it should be "OFF" (#423) * backport: feature(sysex): more efficient screen updates + switch type at runtime Instead of having the client poll the screen with regular intervals, this instead has the deluge push out updates whenever the screen changes. This should dramatically reduce the CPU overhead of this feature when there is no changes to the OLED display. Implement throttling by checking the fullness of the sysex send buffer. This naturally reduces the refresh rate as needed when using serial MIDI, or some USB device which reading too slow he client still has to continuously ask the deluge for updates, to stop sending after the client disconnects. This can be done with a much lower rate, one short message per second. The client can also force a full update so a dropped delta message does not cause the screen to be corrupt forever. In addition, based on the recent display unification work, it is now possible to switch the screen type at runtime from the client. * Ported release branch being included in PR workflow to release branch * Automation View: Resolve Issue #411 : Pad selection mode enhancement to switch between short and long presses (#415) * Master compressor in Arranger view (#420) --------- Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com> Co-authored-by: Paul Freund <freund.paul@lvl3.org> Co-authored-by: Jamie Fenton <jamie@fentonia.com> Co-authored-by: 0beron <robin.fairey@gmail.com> Co-authored-by: Dan Weaver <dan@weaver.media> Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> Co-authored-by: bfredl <bjorn.linse@gmail.com> Co-authored-by: Alter <135567612+alter-alter@users.noreply.github.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Update Stutter Rate Quantize in community_features.md * Update community_features.md * Load synth presets into kit rows (#395) Use the Sound->readFromFile method to load a synth preset into a kit row after setting up the browser for synths. Errors in param manager creation occur with repeated fast scrolling and are handled by aborting the load * Fixed Automation Editor Popup Issues when Loading/Saving (#396) * Fix Automation Editor Popup Issues Fixed issue with Parameter Name Popup hiding Load/Save UI. Also at same time removed some popup code in Sound Editor that wasn't necessary anymore * Update automation_view.md * reset loading synth to kit row * only load audio files if the param manager got created * Update link for PR #395 in Community Features.md * Update community_features.md Just re-ordered a section * Fill clips (#196) * Fill mode for status pads first cut * Single clip fills working and all done in Session::scheduleFillClips * ConextMenuLaunchStyle put into folders, includes fixed * Attempt to fix fill quantization time * Single clip scheduling working correctly, and more self contained. * Updated launchStyle context menu to match upstream refactor * Save/load clip launch style to/from the song file * Fill clips that are playing now insta-stop when status pad pressed. * Updated fillmode branch to match definitions_cxx.hpp * Section triggers for fill clips and enforce one clip per output * Removed some easy gotos * Fixed context menu, implemented repeat count for fill scheduling. * clang format * Docs for fill clips in community features * Tidy up * Dim pads for fills in grid mode. * Updated Community Features link to Release 1.0 branch (#398) * enable CI build on release branch (#400) * Temporarily redirect nightly builds to release branch (#404) * Temporarily redirect pages and nightly builds to release branch * Reverted page changes since they would require more repo setting changes * Updated docs for session::doLaunch * clang format * Moved fill clip strings to l10n and removed last HAVE_OLED * Renumbered features in PR order in community features doc --------- Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com> Co-authored-by: Mark Adams <52469396+m-m-adams@users.noreply.github.com> Co-authored-by: Paul Freund <freund.paul@lvl3.org> * Fixed clip button blinking in Audio Clip View (#397) Leverages a function from Session View to identify the Clip Type while in Song View and using an array from Arranger view to identify the Clip Type while in Arranger View. * Fill mode fixes (#399) * Show FILL conditional value for notes set to fill mode. * Improve sync scaling button runtime setting display on OLED. * Fix some appearances of "DISABLED" in menus where it should be "OFF" (#423) * backport: feature(sysex): more efficient screen updates + switch type at runtime Instead of having the client poll the screen with regular intervals, this instead has the deluge push out updates whenever the screen changes. This should dramatically reduce the CPU overhead of this feature when there is no changes to the OLED display. Implement throttling by checking the fullness of the sysex send buffer. This naturally reduces the refresh rate as needed when using serial MIDI, or some USB device which reading too slow he client still has to continuously ask the deluge for updates, to stop sending after the client disconnects. This can be done with a much lower rate, one short message per second. The client can also force a full update so a dropped delta message does not cause the screen to be corrupt forever. In addition, based on the recent display unification work, it is now possible to switch the screen type at runtime from the client. * Fix #402 global stutter being disengaged on clip launching * Fix clips jumping to different tracks in Grid layout * Fixed vertical scroll direction * Ported release branch being included in PR workflow to release branch * Automation View: Resolve Issue #411 : Pad selection mode enhancement to switch between short and long presses (#415) * Master compressor in Arranger view (#420) * Allow Norns layout to display incoming notes without learning the input and make highlight incoming notes default behavior to get user feedback (#389) * Norns layout without learning, might need to add filtering for the same MIDI channel later * Forgot DBT format * Only highlight on the right channel * Default enable highlighting incoming notes * remove broken audio fold, add working filt selection * remove unused svf string * use l10n for filter mode switching * Bugfixes for fill mode (#450) * treat cc value 0 as a note off for fill mode * prevent allowing latching in fill mode * respect fill and default probability for live recording * respect fill and default probability for placing notes * respect fill and probability for euclidean notes * Fix #382 scrolling not adjusted to entered clip * Fix #419 load and delete buttons not turning off * Fix #413 scroll not invalidating grid selection * Automation View: show Synth/Kit parameter names for 7Seg * String cleanup + 7seg parameter name activation * Updated 7seg to display scrolling parameter names * Interpolation Correction to Eliminate Unexpected Behaviour Minor change to interpolation before/after code when setting parameter automation values. I wasn't creating a node immediately right of the node where the value is being set which is why I believe there was an interpolation bug being observed in a weird edge case. * Fixed pop up issues identified by @trappar (#456) In Issue #440 @trappar identified some weird pop up values being displayed on the screen when editing after touch and pressure. This is because the deluge was displaying pop up values at the same time as I was displaying pop up values in the deluge so it basically giving weird behaviour of overlapping popups and not showing the right value. I've corrected this by putting a condition in the deluge function that was displaying the popup to say: "if in automation view, let the automation view handle the drawing of popups. I did the same thing previously in another function called MidiParamCollection::knobPosToParamValue I didn't realize then that there was another function being used in midi clips to display popups for Pitch Bend and After Touch (ExpressionParamSet::knobPosToParamValue) * Automation view: handle very rapid region entry Refactored code for a single press to its own separate function Recorded a second pad press for the second pad press in a long press which should resolve issues with deselection Also allows for further control of long presses by giving the user freedom to let go of the first pad and continue holding the second pad and still be able to edit the long press. * fix crash while loading synth to kit row (#460) * Ensure that the drum isn't currently in use before we replace it * Stop the note currently sounding * Remove notes which are about to sound * Automation View: Use of Sidebar + Auditioning of last selected value Audition pads in automation view now use last selected value if sequencer not running When a long press is selected in pad selection mode and you peek the value of the start or end position of the long press, it should tell you the value at the very first node and very last node respectively. Previously it was showing the middle value. Fixed issue whereby holding audition pad and changing pad selection wasn't updating auditioned parameter values * Adjust threshold for midi knob sync For MIDI Takeover modes Pickup and Scale, an adjustment is required to allow for fast value changes resulting from fast midi controller actions. Currently the Deluge goes out of sync with the controller if the controller changes the value too fast. To resolve this, the previous threshold of +/- 1 was increased to +/- 3. The code was also tidied up a bit as part of this change. * Automation view: hold open selection mode value popup * Updated threshold to 5 * Fixes #437 (#464) --------- Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com> Co-authored-by: Paul Freund <freund.paul@lvl3.org> Co-authored-by: Jamie Fenton <jamie@fentonia.com> Co-authored-by: 0beron <robin.fairey@gmail.com> Co-authored-by: Dan Weaver <dan@weaver.media> Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> Co-authored-by: bfredl <bjorn.linse@gmail.com> Co-authored-by: Alter <135567612+alter-alter@users.noreply.github.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Update Stutter Rate Quantize in community_features.md * Update community_features.md * Load synth presets into kit rows (#395) Use the Sound->readFromFile method to load a synth preset into a kit row after setting up the browser for synths. Errors in param manager creation occur with repeated fast scrolling and are handled by aborting the load * Fixed Automation Editor Popup Issues when Loading/Saving (#396) * Fix Automation Editor Popup Issues Fixed issue with Parameter Name Popup hiding Load/Save UI. Also at same time removed some popup code in Sound Editor that wasn't necessary anymore * Update automation_view.md * reset loading synth to kit row * only load audio files if the param manager got created * Update link for PR #395 in Community Features.md * Update community_features.md Just re-ordered a section * Fill clips (#196) * Fill mode for status pads first cut * Single clip fills working and all done in Session::scheduleFillClips * ConextMenuLaunchStyle put into folders, includes fixed * Attempt to fix fill quantization time * Single clip scheduling working correctly, and more self contained. * Updated launchStyle context menu to match upstream refactor * Save/load clip launch style to/from the song file * Fill clips that are playing now insta-stop when status pad pressed. * Updated fillmode branch to match definitions_cxx.hpp * Section triggers for fill clips and enforce one clip per output * Removed some easy gotos * Fixed context menu, implemented repeat count for fill scheduling. * clang format * Docs for fill clips in community features * Tidy up * Dim pads for fills in grid mode. * Updated Community Features link to Release 1.0 branch (#398) * enable CI build on release branch (#400) * Temporarily redirect nightly builds to release branch (#404) * Temporarily redirect pages and nightly builds to release branch * Reverted page changes since they would require more repo setting changes * Updated docs for session::doLaunch * clang format * Moved fill clip strings to l10n and removed last HAVE_OLED * Renumbered features in PR order in community features doc --------- Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com> Co-authored-by: Mark Adams <52469396+m-m-adams@users.noreply.github.com> Co-authored-by: Paul Freund <freund.paul@lvl3.org> * Fixed clip button blinking in Audio Clip View (#397) Leverages a function from Session View to identify the Clip Type while in Song View and using an array from Arranger view to identify the Clip Type while in Arranger View. * Fill mode fixes (#399) * Show FILL conditional value for notes set to fill mode. * Improve sync scaling button runtime setting display on OLED. * Fix some appearances of "DISABLED" in menus where it should be "OFF" (#423) * backport: feature(sysex): more efficient screen updates + switch type at runtime Instead of having the client poll the screen with regular intervals, this instead has the deluge push out updates whenever the screen changes. This should dramatically reduce the CPU overhead of this feature when there is no changes to the OLED display. Implement throttling by checking the fullness of the sysex send buffer. This naturally reduces the refresh rate as needed when using serial MIDI, or some USB device which reading too slow he client still has to continuously ask the deluge for updates, to stop sending after the client disconnects. This can be done with a much lower rate, one short message per second. The client can also force a full update so a dropped delta message does not cause the screen to be corrupt forever. In addition, based on the recent display unification work, it is now possible to switch the screen type at runtime from the client. * Fix #402 global stutter being disengaged on clip launching * Fix clips jumping to different tracks in Grid layout * Fixed vertical scroll direction * Ported release branch being included in PR workflow to release branch * Automation View: Resolve Issue #411 : Pad selection mode enhancement to switch between short and long presses (#415) * Master compressor in Arranger view (#420) * Allow Norns layout to display incoming notes without learning the input and make highlight incoming notes default behavior to get user feedback (#389) * Norns layout without learning, might need to add filtering for the same MIDI channel later * Forgot DBT format * Only highlight on the right channel * Default enable highlighting incoming notes * remove broken audio fold, add working filt selection * remove unused svf string * use l10n for filter mode switching * Bugfixes for fill mode (#450) * treat cc value 0 as a note off for fill mode * prevent allowing latching in fill mode * respect fill and default probability for live recording * respect fill and default probability for placing notes * respect fill and probability for euclidean notes * Fix #382 scrolling not adjusted to entered clip * Fix #419 load and delete buttons not turning off * Fix #413 scroll not invalidating grid selection * Automation View: show Synth/Kit parameter names for 7Seg * String cleanup + 7seg parameter name activation * Updated 7seg to display scrolling parameter names * Interpolation Correction to Eliminate Unexpected Behaviour Minor change to interpolation before/after code when setting parameter automation values. I wasn't creating a node immediately right of the node where the value is being set which is why I believe there was an interpolation bug being observed in a weird edge case. * Fixed pop up issues identified by @trappar (#456) In Issue #440 @trappar identified some weird pop up values being displayed on the screen when editing after touch and pressure. This is because the deluge was displaying pop up values at the same time as I was displaying pop up values in the deluge so it basically giving weird behaviour of overlapping popups and not showing the right value. I've corrected this by putting a condition in the deluge function that was displaying the popup to say: "if in automation view, let the automation view handle the drawing of popups. I did the same thing previously in another function called MidiParamCollection::knobPosToParamValue I didn't realize then that there was another function being used in midi clips to display popups for Pitch Bend and After Touch (ExpressionParamSet::knobPosToParamValue) * Automation view: handle very rapid region entry Refactored code for a single press to its own separate function Recorded a second pad press for the second pad press in a long press which should resolve issues with deselection Also allows for further control of long presses by giving the user freedom to let go of the first pad and continue holding the second pad and still be able to edit the long press. * fix crash while loading synth to kit row (#460) * Ensure that the drum isn't currently in use before we replace it * Stop the note currently sounding * Remove notes which are about to sound * Automation View: Use of Sidebar + Auditioning of last selected value Audition pads in automation view now use last selected value if sequencer not running When a long press is selected in pad selection mode and you peek the value of the start or end position of the long press, it should tell you the value at the very first node and very last node respectively. Previously it was showing the middle value. Fixed issue whereby holding audition pad and changing pad selection wasn't updating auditioned parameter values * Adjust threshold for midi knob sync For MIDI Takeover modes Pickup and Scale, an adjustment is required to allow for fast value changes resulting from fast midi controller actions. Currently the Deluge goes out of sync with the controller if the controller changes the value too fast. To resolve this, the previous threshold of +/- 1 was increased to +/- 3. The code was also tidied up a bit as part of this change. * Automation view: hold open selection mode value popup * Updated threshold to 5 * Fixes #437 (#464) --------- Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com> Co-authored-by: Paul Freund <freund.paul@lvl3.org> Co-authored-by: Jamie Fenton <jamie@fentonia.com> Co-authored-by: 0beron <robin.fairey@gmail.com> Co-authored-by: Dan Weaver <dan@weaver.media> Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> Co-authored-by: bfredl <bjorn.linse@gmail.com> Co-authored-by: Alter <135567612+alter-alter@users.noreply.github.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
* Update Stutter Rate Quantize in community_features.md * Update community_features.md * Load synth presets into kit rows (#395) Use the Sound->readFromFile method to load a synth preset into a kit row after setting up the browser for synths. Errors in param manager creation occur with repeated fast scrolling and are handled by aborting the load * Fixed Automation Editor Popup Issues when Loading/Saving (#396) * Fix Automation Editor Popup Issues Fixed issue with Parameter Name Popup hiding Load/Save UI. Also at same time removed some popup code in Sound Editor that wasn't necessary anymore * Update automation_view.md * reset loading synth to kit row * only load audio files if the param manager got created * Update link for PR #395 in Community Features.md * Update community_features.md Just re-ordered a section * Fill clips (#196) * Fill mode for status pads first cut * Single clip fills working and all done in Session::scheduleFillClips * ConextMenuLaunchStyle put into folders, includes fixed * Attempt to fix fill quantization time * Single clip scheduling working correctly, and more self contained. * Updated launchStyle context menu to match upstream refactor * Save/load clip launch style to/from the song file * Fill clips that are playing now insta-stop when status pad pressed. * Updated fillmode branch to match definitions_cxx.hpp * Section triggers for fill clips and enforce one clip per output * Removed some easy gotos * Fixed context menu, implemented repeat count for fill scheduling. * clang format * Docs for fill clips in community features * Tidy up * Dim pads for fills in grid mode. * Updated Community Features link to Release 1.0 branch (#398) * enable CI build on release branch (#400) * Temporarily redirect nightly builds to release branch (#404) * Temporarily redirect pages and nightly builds to release branch * Reverted page changes since they would require more repo setting changes * Updated docs for session::doLaunch * clang format * Moved fill clip strings to l10n and removed last HAVE_OLED * Renumbered features in PR order in community features doc --------- Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com> Co-authored-by: Mark Adams <52469396+m-m-adams@users.noreply.github.com> Co-authored-by: Paul Freund <freund.paul@lvl3.org> * Fixed clip button blinking in Audio Clip View (#397) Leverages a function from Session View to identify the Clip Type while in Song View and using an array from Arranger view to identify the Clip Type while in Arranger View. * Fill mode fixes (#399) * Show FILL conditional value for notes set to fill mode. * Improve sync scaling button runtime setting display on OLED. * Fix some appearances of "DISABLED" in menus where it should be "OFF" (#423) * backport: feature(sysex): more efficient screen updates + switch type at runtime Instead of having the client poll the screen with regular intervals, this instead has the deluge push out updates whenever the screen changes. This should dramatically reduce the CPU overhead of this feature when there is no changes to the OLED display. Implement throttling by checking the fullness of the sysex send buffer. This naturally reduces the refresh rate as needed when using serial MIDI, or some USB device which reading too slow he client still has to continuously ask the deluge for updates, to stop sending after the client disconnects. This can be done with a much lower rate, one short message per second. The client can also force a full update so a dropped delta message does not cause the screen to be corrupt forever. In addition, based on the recent display unification work, it is now possible to switch the screen type at runtime from the client. * Fix #402 global stutter being disengaged on clip launching * Fix clips jumping to different tracks in Grid layout * Fixed vertical scroll direction * Ported release branch being included in PR workflow to release branch * Automation View: Resolve Issue #411 : Pad selection mode enhancement to switch between short and long presses (#415) * Master compressor in Arranger view (#420) * Allow Norns layout to display incoming notes without learning the input and make highlight incoming notes default behavior to get user feedback (#389) * Norns layout without learning, might need to add filtering for the same MIDI channel later * Forgot DBT format * Only highlight on the right channel * Default enable highlighting incoming notes * remove broken audio fold, add working filt selection * remove unused svf string * use l10n for filter mode switching * Bugfixes for fill mode (#450) * treat cc value 0 as a note off for fill mode * prevent allowing latching in fill mode * respect fill and default probability for live recording * respect fill and default probability for placing notes * respect fill and probability for euclidean notes * Fix #382 scrolling not adjusted to entered clip * Fix #419 load and delete buttons not turning off * Fix #413 scroll not invalidating grid selection * Automation View: show Synth/Kit parameter names for 7Seg * String cleanup + 7seg parameter name activation * Updated 7seg to display scrolling parameter names * Interpolation Correction to Eliminate Unexpected Behaviour Minor change to interpolation before/after code when setting parameter automation values. I wasn't creating a node immediately right of the node where the value is being set which is why I believe there was an interpolation bug being observed in a weird edge case. * Fixed pop up issues identified by @trappar (#456) In Issue #440 @trappar identified some weird pop up values being displayed on the screen when editing after touch and pressure. This is because the deluge was displaying pop up values at the same time as I was displaying pop up values in the deluge so it basically giving weird behaviour of overlapping popups and not showing the right value. I've corrected this by putting a condition in the deluge function that was displaying the popup to say: "if in automation view, let the automation view handle the drawing of popups. I did the same thing previously in another function called MidiParamCollection::knobPosToParamValue I didn't realize then that there was another function being used in midi clips to display popups for Pitch Bend and After Touch (ExpressionParamSet::knobPosToParamValue) * Automation view: handle very rapid region entry Refactored code for a single press to its own separate function Recorded a second pad press for the second pad press in a long press which should resolve issues with deselection Also allows for further control of long presses by giving the user freedom to let go of the first pad and continue holding the second pad and still be able to edit the long press. * fix crash while loading synth to kit row (#460) * Ensure that the drum isn't currently in use before we replace it * Stop the note currently sounding * Remove notes which are about to sound * Automation View: Use of Sidebar + Auditioning of last selected value Audition pads in automation view now use last selected value if sequencer not running When a long press is selected in pad selection mode and you peek the value of the start or end position of the long press, it should tell you the value at the very first node and very last node respectively. Previously it was showing the middle value. Fixed issue whereby holding audition pad and changing pad selection wasn't updating auditioned parameter values * Adjust threshold for midi knob sync For MIDI Takeover modes Pickup and Scale, an adjustment is required to allow for fast value changes resulting from fast midi controller actions. Currently the Deluge goes out of sync with the controller if the controller changes the value too fast. To resolve this, the previous threshold of +/- 1 was increased to +/- 3. The code was also tidied up a bit as part of this change. * Automation view: hold open selection mode value popup * Updated threshold to 5 * Fixes #437 (#464) * chore: fix ODR violations (#469) * Remove fmtlib (#465) * remove fmtlib from patch cables * remove vformat in formattedtitle * remove fmt from gate and cv menus * remove fmt from sysex and remove fmt dependency * Revert "Merge release fixes into community (#470)" This reverts commit 3ac350d. * Revert "Merge in release fixes (#446)" This reverts commit 68e724a. --------- Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com> Co-authored-by: Paul Freund <freund.paul@lvl3.org> Co-authored-by: Jamie Fenton <jamie@fentonia.com> Co-authored-by: 0beron <robin.fairey@gmail.com> Co-authored-by: Dan Weaver <dan@weaver.media> Co-authored-by: Katherine Whitlock <kate@skylinesynths.nyc> Co-authored-by: bfredl <bjorn.linse@gmail.com> Co-authored-by: Alter <135567612+alter-alter@users.noreply.github.com> Co-authored-by: Reed Koser <srkoser+GitHub@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pseudo draft - it's working but hacky, I need to do a review and figure out what can get cut back now