keyboardScreen: support multiple note layouts#46
Merged
Conversation
This was referenced Jun 11, 2023
Closed
bfredl
force-pushed
the
notelayout
branch
3 times, most recently
from
June 23, 2023 18:11
ebe93dc to
a6bb966
Compare
bfredl
force-pushed
the
notelayout
branch
2 times, most recently
from
June 28, 2023 09:31
dc75098 to
d520cbc
Compare
bfredl
marked this pull request as ready for review
June 28, 2023 09:31
Collaborator
Author
|
Updated. row spacing is stored as part of an instrument clip, just like the overall scroll position of the keyboard. UI now works fine on the OLED with a popup. This could use a quick test from someone with a 7SEG as well. |
bfredl
force-pushed
the
notelayout
branch
3 times, most recently
from
June 28, 2023 15:49
32a3077 to
ada7fdd
Compare
shift + <|> to change row offset. Limited to offsets between 1-12 seems reasonable (max value gives octave shift) Saved/loaded as part of a clip (just like the keyboard position)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #19
shift + <|> to change row offset. Limited to offsets between 1-12 seems reasonable (max value gives octave shift).
allowing offset=0 would make sense together with rows being mapped to velocity instead (could be a followup).