Fine tuning / Add two pad single column press in automation view + Adjust Pitch Display Range - #887
Merged
Conversation
- Adjusted the 4th pad from bottom to select the middle parameter value (25/50) - Adjusted the 5th pad from bottom to 28/50 to 30/50
In automation view, pitch parameters now display with the -25 to +25 value range if Master Pitch is mapped to a mod encoder, it will also display the -25 to +25 range
… of https://github.com/seangoodvibes/DelugeFirmware into Set-middle-value-in-Automation-View-to-Neutral-(25/50)
seangoodvibes
changed the title
seangoodvibes
marked this pull request as draft
December 25, 2023 21:33
You now enter a two pad press in a single column to set the parameter value for that column to the middle point between the two pads (e.g. pressing 4 and 5 will set the value to the middle 25/50).
… of https://github.com/seangoodvibes/DelugeFirmware into Set-middle-value-in-Automation-View-to-Neutral-(25/50)
seangoodvibes
marked this pull request as ready for review
December 25, 2023 21:59
seangoodvibes
changed the title
m-m-adams
approved these changes
Jan 3, 2024
m-m-adams
added this pull request to the merge queue
Jan 5, 2024
seangoodvibes
added a commit
that referenced
this pull request
Jan 6, 2024
Description was changed in error in PR #887
seangoodvibes
added a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 6, 2024
…just Pitch Display Range (SynthstromAudible#887) * Adjust pad press values in automation view - Adjusted the 4th pad from bottom to select the middle parameter value (25/50) - Adjusted the 5th pad from bottom to 28/50 to 30/50 * Update automation_view.md * Adjusted display value range for pitch parameters In automation view, pitch parameters now display with the -25 to +25 value range if Master Pitch is mapped to a mod encoder, it will also display the -25 to +25 range * Adjust format * Update automation_view.md * Added ability to press two pads in a single column You now enter a two pad press in a single column to set the parameter value for that column to the middle point between the two pads (e.g. pressing 4 and 5 will set the value to the middle 25/50).
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
Description was changed in error in PR #887
seangoodvibes
deleted the
Set-middle-value-in-Automation-View-to-Neutral-(25/50)
branch
February 22, 2024 23:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Received recommendation (see #802) to be able to quickly set parameter value back to neutral (0 or 25/50) when pressing one of the middle pads in automation view.
Example given was that it was difficult it to go back to Neutral Pitch change after changing the sound with the Master Pitch parameter.
To address this request, I have now made it possible to set the parameter value to the middle point between two pads pressed in a single column. E.g. press pads 4 and 5 to set the value to 25/50.
Additional Change: