Enhancement / Mod Encoders ~ Add Mod Button Gold Knob Contextual Popups#888
Merged
m-m-adams merged 11 commits intoJan 28, 2024
Merged
Conversation
seangoodvibes
changed the title
seangoodvibes
changed the title
seangoodvibes
force-pushed
the
Add-Mod-Button-Context-Popups
branch
from
8d52eca to
af20901
Compare
seangoodvibes
changed the title
seangoodvibes
changed the title
seangoodvibes
changed the title
seangoodvibes
force-pushed
the
Add-Mod-Button-Context-Popups
branch
5 times, most recently
from
72fc905 to
c46221c
Compare
seangoodvibes
force-pushed
the
Add-Mod-Button-Context-Popups
branch
5 times, most recently
from
a184336 to
74a2b1f
Compare
seangoodvibes
force-pushed
the
Add-Mod-Button-Context-Popups
branch
2 times, most recently
from
24b2444 to
2651708
Compare
seangoodvibes
changed the title
m-m-adams
requested changes
Jan 26, 2024
seangoodvibes
force-pushed
the
Add-Mod-Button-Context-Popups
branch
from
208b863 to
0004a64
Compare
seangoodvibes
changed the title
seangoodvibes
force-pushed
the
Add-Mod-Button-Context-Popups
branch
2 times, most recently
from
c803e73 to
94ee925
Compare
m-m-adams
approved these changes
Jan 28, 2024
Added: EQ, Reverb, Sidechain Compressor
Added Global LPF, HPF, EQ, MOD FX
Added: Delay, Master Comp, Reverb
Right now it only works for OLED. I just structured the code so that I can add the 7seg pop-up's next
Renaming to sidechain to align with PR SynthstromAudible#898
seangoodvibes
force-pushed
the
Add-Mod-Button-Context-Popups
branch
from
94ee925 to
c3969d8
Compare
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
…ps (SynthstromAudible#888) * display LPF, HPF, Delay * Add more params Added: EQ, Reverb, Sidechain Compressor * Added Global Params Added Global LPF, HPF, EQ, MOD FX * Add remaining global FX Added: Delay, Master Comp, Reverb * Prepare for adding 7Seg Support Right now it only works for OLED. I just structured the code so that I can add the 7seg pop-up's next * Add 7SEG + Code refactoring / cleanup * Fixup * Rename Sidechain Compressor to Sidechain Renaming to sidechain to align with PR SynthstromAudible#898 * dbt format * Fix rebase mistake * Update per feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you press on the gold knob mod buttons to switch what the gold knobs control, it now displays a pop-up to tell you what the current settings are for the current Gold Knob parameters selected.
For example, if you press the LPF/HPF/EQ button it will tell you if you have currently selected LPF, HPF, or EQ. If you have selected LPF or HPF, it will also tell you the mode - e.g. LPF: 24DB
On 7SEG the pop-up is split into two actions (press and release): e.g. for LPF, when you press down on the button it will display LPF, and when you let go of the button it will display 24DB.