Feature/option to combine mpe to monophonic midi output - #934
Merged
sapphire-arches merged 15 commits intoJan 15, 2024
Merged
Conversation
m-m-adams
force-pushed
the
feature/combine_mpe_to_mono
branch
3 times, most recently
from
January 14, 2024 17:20
c3117f6 to
dedb1ac
Compare
sapphire-arches
left a comment
sapphire-arches
left a comment
Collaborator
There was a problem hiding this comment.
mostly stupid style nitpicks, functionally i don't see any obvious problems
… transmitted at half value
m-m-adams
force-pushed
the
feature/combine_mpe_to_mono
branch
from
January 15, 2024 01:13
dedb1ac to
91fd35e
Compare
sapphire-arches
enabled auto-merge
January 15, 2024 01:32
sapphire-arches
added this pull request to the merge queue
Jan 15, 2024
seangoodvibes
pushed a commit
to seangoodvibes/DelugeFirmware
that referenced
this pull request
Jan 15, 2024
…dible#934) * collapse MPE to monophonic expression, aftertouch to poly aftertouch by default * add mpe submenu to midi output * fix getcurrentinstrumenttype to be safe * menu for setting and saving poly to mono conversion data * rename menu for clarity * format and documentation * adjust bend range when converting from mpe pitch to mono pitch * remove non-functional check * ensure mod wheel can work when negative * combine mono pitch/mod with collapsed poly expression * fix bug where mod wheel was transmitted twice, fix bug where modwheel transmitted at half value * reset monophonic MPE values on note off * fix merge issue * initialize all expression to 0 * address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convenience settings for MPE and poly aftertouch users
Adds two settings to midi outputs to combine poly expression to mono. The aftertouch option converts MPE and poly aftertouch to mono aftertouch (highest pressure wins), the MPE option converts y-axis to mod wheel (highest wins) and poly pitch bend to average mono pitch bend.
This makes using an MPE controller with midi follow much more convenient