Skip to content

Streamline recording new clips while Deluge is playing#970

Merged
PaulFreund merged 3 commits intoSynthstromAudible:communityfrom
cowboy:rec-on-empty-clip-press
Jan 14, 2024
Merged

Streamline recording new clips while Deluge is playing#970
PaulFreund merged 3 commits intoSynthstromAudible:communityfrom
cowboy:rec-on-empty-clip-press

Conversation

@cowboy
Copy link
Copy Markdown
Contributor

@cowboy cowboy commented Jan 14, 2024

This assumes Deluge is in grid mode, Deluge is playing, and Rec is enabled.

The following steps assume default active is set to green, but should work regardless of how default active is set. The updated behavior works in green mode.

Instead of:

  1. Hold blue mode button + long-press empty clip pad(s) to create clip(s)
  2. Short-press clip(s) created in step 1 to queue them up for recording at the beginning of the next bar
  3. Record clip(s)

This allows one to:

  1. Short-press empty clip pad(s) to create clip(s) and queue them up for recording at the beginning of the next bar
  2. Record clip(s)

In my testing, this makes recording new clips significantly easier.

@PaulFreund
Copy link
Copy Markdown
Collaborator

Hey there, really cool! :) Didn't look at the code yet but I'm sure a lot of people will find that useful. In order to properly integrate it I propose to change "Empty pad unarm" which is On/Off currently into "Empty pad action" where the user can select between Nothing, Unarm and Create+Record. What do you think?

In addition I am planning a red mode for punch in and punch out recording, if you are interested to pick it up you can highlight me and we can figure out the details on Discord.

@sichtbeton
Copy link
Copy Markdown
Contributor

sichtbeton commented Jan 14, 2024

Hey there, really cool! :) Didn't look at the code yet but I'm sure a lot of people will find that useful. In order to properly integrate it I propose to change "Empty pad unarm" which is On/Off currently into "Empty pad action" where the user can select between Nothing, Unarm and Create+Record. What do you think?

In addition I am planning a red mode for punch in and punch out recording, if you are interested to pick it up you can highlight me and we can figure out the details on Discord.

Question: couldn’t these two functions coexist? They are differentiated by rec enabled.

You could unarm with empty while no rec is enabled and record when rec is enabled.

@cowboy
Copy link
Copy Markdown
Contributor Author

cowboy commented Jan 14, 2024

To @sichtbeton's point, I actually use both unarm and create+record together. I've added some code which creates an "Empty pads" submenu with independent "Unarm" and "Create + Record" bool toggles.

@PaulFreund
Copy link
Copy Markdown
Collaborator

Ah very nice, that works for me as well :) Once you are ready feel free to request a review after converting from Draft to ready.

@cowboy cowboy marked this pull request as ready for review January 14, 2024 14:53
@cowboy
Copy link
Copy Markdown
Contributor Author

cowboy commented Jan 14, 2024

There's nothing else I want to add to this PR, so I think it's ready for review. I hope others will test it, in case I missed anything important!

@cowboy cowboy force-pushed the rec-on-empty-clip-press branch from ceaabc7 to 291c7b2 Compare January 14, 2024 16:03
Copy link
Copy Markdown
Collaborator

@PaulFreund PaulFreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder that currentSong->currentClip will need to be updated later

@PaulFreund PaulFreund added this pull request to the merge queue Jan 14, 2024
Merged via the queue into SynthstromAudible:community with commit e14fdb7 Jan 14, 2024
@cowboy
Copy link
Copy Markdown
Contributor Author

cowboy commented Jan 14, 2024

Just a reminder that currentSong->currentClip will need to be updated later

See #973

seangoodvibes added a commit that referenced this pull request Feb 27, 2024
Added PR #970 to the community features documentation
seangoodvibes added a commit that referenced this pull request Feb 27, 2024
Updated description for PR #970 in the change log
github-merge-queue Bot pushed a commit that referenced this pull request Feb 27, 2024
* Update PR #970 in community features

Added PR #970 to the community features documentation

* Update CHANGELOG.md

Updated description for PR #970 in the change log
github-actions Bot pushed a commit that referenced this pull request Feb 27, 2024
* Update PR #970 in community features

Added PR #970 to the community features documentation

* Update CHANGELOG.md

Updated description for PR #970 in the change log
stellar-aria pushed a commit that referenced this pull request Feb 27, 2024
* Update PR #970 in community features

Added PR #970 to the community features documentation

* Update CHANGELOG.md

Updated description for PR #970 in the change log
seangoodvibes added a commit that referenced this pull request Mar 5, 2024
Updated community features documentation for PR #970
github-merge-queue Bot pushed a commit that referenced this pull request Mar 5, 2024
Updated community features documentation for PR #970
github-actions Bot pushed a commit that referenced this pull request Mar 5, 2024
Updated community features documentation for PR #970
m-m-adams added a commit that referenced this pull request Mar 5, 2024
….1-e5c8a3e25a49f9d61108ee920ef455492464a30b

Update documentation for PR #970
@solaris76
Copy link
Copy Markdown
Contributor

Minor one; Documentation 'a' should read as below: ("SONG" missing).
Enter SETTINGS > DEFAULTS > UI > SONG > GRID > EMPTY PADS > CREATE + RECORD and select ENABLED

tastycode pushed a commit to tastycode/DelugeFirmware that referenced this pull request Jul 3, 2024
…ble#1360)

* Update PR SynthstromAudible#970 in community features

Added PR SynthstromAudible#970 to the community features documentation

* Update CHANGELOG.md

Updated description for PR SynthstromAudible#970 in the change log
tastycode pushed a commit to tastycode/DelugeFirmware that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants