Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward MockFileInfo.Open* to MockFile.Open* #619

Merged
merged 1 commit into from Jun 23, 2020
Merged

Forward MockFileInfo.Open* to MockFile.Open* #619

merged 1 commit into from Jun 23, 2020

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Jun 23, 2020 •
edited

fgreinacher referenced this pull request Jun 23, 2020
@fgreinacher
fix(TestingHelpers): correctly handle FileMode/FileAccess when creati…
efef869 
…ng MockFileStreams (#618)

BREAKING CHANGE: MockFileStream.StreamType and the related constructors are gone. The desired behavior should be specified by passing the appropriate FileMode/FileAccess/FileOptions in the constructor instead.

Fixes #610
@fgreinacher fgreinacher changed the title refactor: forward MockFileInfo.Open* to MockFile.Open* Forward MockFileInfo.Open* to MockFile.Open* Jun 23, 2020
@fgreinacher fgreinacher merged commit 2b7431a into master Jun 23, 2020
@fgreinacher fgreinacher deleted the fix/open-write branch June 23, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fgreinacher