Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Prepared Patterns #91

Closed
danon opened this issue Jan 25, 2021 · 0 comments
Closed

Revamp Prepared Patterns #91

danon opened this issue Jan 25, 2021 · 0 comments

Comments

@danon
Copy link
Member

danon commented Jan 25, 2021

Pattern::inject('\@', [$value]);  // This is being debated

Pattern::inject('[@]', [$value]);     // doesn't work with alteration or an empty string
Pattern::inject('\Q@\E', [$value]);   // This should probably treat it as "@" literal
Pattern::inject('\Q\@\E', [$value]);  // This should probably treat it as "\@" literal
Pattern::inject('\Q[@]\E', [$value]); // This should probably treat it as "[@]" literal
Pattern::inject('#@', [$value], 'x'); // This seams to work out of the box
Pattern::inject('#[@]', [$value], 'x'); // This seams to work out of the box
Pattern::inject('#\Q[@]\E', [$value], 'x'); // This seams to work out of the box
@danon danon self-assigned this Apr 3, 2021
@danon danon changed the title What to do with quoted prepared values? r May 16, 2021
@danon danon changed the title r Revamp Prepared Patterns May 16, 2021
danon added a commit that referenced this issue Jun 1, 2021
danon added a commit that referenced this issue Jun 2, 2021
danon added a commit that referenced this issue Jun 15, 2021
danon added a commit that referenced this issue Jun 17, 2021
danon added a commit that referenced this issue Jun 17, 2021
danon added a commit that referenced this issue Jun 17, 2021
danon added a commit that referenced this issue Jun 17, 2021
danon added a commit that referenced this issue Jun 17, 2021
danon added a commit that referenced this issue Jun 18, 2021
danon added a commit that referenced this issue Jun 18, 2021
danon added a commit that referenced this issue Jun 18, 2021
danon added a commit that referenced this issue Jun 18, 2021
danon added a commit that referenced this issue Jun 18, 2021
danon added a commit that referenced this issue Jun 18, 2021
@danon danon pinned this issue Jun 30, 2021
danon added a commit that referenced this issue Jul 2, 2021
danon added a commit that referenced this issue Jul 2, 2021
danon added a commit that referenced this issue Jul 7, 2021
danon added a commit that referenced this issue Jul 7, 2021
- Extract FiguresPlaceholderConsumer from PlaceholderConsumer
- Add ExpectedFigures to PlaceholderConsumer
@danon danon unpinned this issue Jul 12, 2021
danon added a commit that referenced this issue Jul 13, 2021
danon added a commit that referenced this issue Jul 13, 2021
- Extract FiguresPlaceholderConsumer from PlaceholderConsumer
- Add ExpectedFigures to PlaceholderConsumer
danon added a commit that referenced this issue Jul 13, 2021
- Extract FiguresPlaceholderConsumer from PlaceholderConsumer
- Add ExpectedFigures to PlaceholderConsumer
@danon danon pinned this issue Jul 15, 2021
@danon danon closed this as completed Jul 15, 2021
danon added a commit that referenced this issue Jul 16, 2021
danon added a commit that referenced this issue Jul 16, 2021
- Extract FiguresPlaceholderConsumer from PlaceholderConsumer
- Add ExpectedFigures to PlaceholderConsumer
@danon danon unpinned this issue Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant