New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/DES-1828 Streetview #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still testing the linking and viewing the segments but wanted to provide some feedback.
Looking good. 👍 . I really like workflow and how the user is provided with great progress information. 💯
src/app/components/streetview-sequence/streetview-sequence.component.html
Outdated
Show resolved
Hide resolved
src/app/components/streetview-panel/streetview-panel.component.styl
Outdated
Show resolved
Hide resolved
… into task/DES-1828
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still working though testing but here are some initial comments/questions
src/app/components/public-map-info-panel/public-map-info-panel.component.html
Outdated
Show resolved
Hide resolved
src/app/components/streetview-logs/streetview-logs.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. 💯 🔥
Just consider this comment before merging.
Overview:
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
UI Photos:
Notes: