Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/DES-1828 Streetview #45

Merged
merged 70 commits into from Apr 27, 2022
Merged

task/DES-1828 Streetview #45

merged 70 commits into from Apr 27, 2022

Conversation

duckonomy
Copy link
Contributor

@duckonomy duckonomy commented Mar 16, 2021

Overview:

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • Separate panel for Streetview
    • Icon?
    • Tabs for Accounts, Upload Log, and Uploaded assets (streamed from Streetview service)
  • Upload Log
    • Separate status indicators for notification types
    • Progress bar
  • Accounts tab for indicating authorization status
    • Auth routing
  • Assets
    • Get mapillary sequence data from geoapi
    • Notify user of pending approval
    • Implement changesets for mapillary
  • Streetview publishing modal
    • Select service (maybe checkbox?
  • Display sequence features in the map
    • Make each feature a marker layer
    • Open link to streetview on clicking point (with image key)
    • Get thumbs from mapillary
    • Lon/lat based mapillary open
    • Split mapillary view

Testing Steps:

  • Use task/DES-1828 Streetview geoapi#46
  • Create a Mapillary account
  • Test that uploads work for streetview images from PRJ-2996
  • Test that linking (just associating streetivew images with existing sequences) works
  • Check that uploaded/linked sequences appear in the asset list and on the map as LineStrings
  • Check that the the split views work (right click on a LineString point).

UI Photos:

HazMapper - Google Chrome_002
HazMapper - Google Chrome_001
HazMapper - Google Chrome_005
HazMapper - Google Chrome_008

Notes:

@duckonomy duckonomy marked this pull request as ready for review April 5, 2021 13:54
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still testing the linking and viewing the segments but wanted to provide some feedback.

Looking good. 👍 . I really like workflow and how the user is provided with great progress information. 💯

src/app/components/map/map.component.ts Outdated Show resolved Hide resolved
src/app/components/map/map.component.ts Outdated Show resolved Hide resolved
src/app/components/map/map.component.ts Outdated Show resolved Hide resolved
src/app/components/map/map.component.ts Outdated Show resolved Hide resolved
src/app/components/map/map.component.ts Outdated Show resolved Hide resolved
src/app/utils/headers.ts Outdated Show resolved Hide resolved
src/app/services/streetview.service.ts Outdated Show resolved Hide resolved
src/app/services/streetview.service.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still working though testing but here are some initial comments/questions

src/app/app.interceptors.ts Show resolved Hide resolved
src/app/app.interceptors.ts Show resolved Hide resolved
src/app/app.interceptors.ts Show resolved Hide resolved
src/app/utils/headers.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. 💯 🔥

Just consider this comment before merging.

@duckonomy duckonomy merged commit 810a97f into master Apr 27, 2022
@nathanfranklin nathanfranklin deleted the task/DES-1828 branch December 15, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants