From 05cefd123ade3cdb96c9ff88caba6123b9eca04b Mon Sep 17 00:00:00 2001
From: Wesley Bomar <wbomar@tacc.utexas.edu>
Date: Tue, 5 Mar 2024 13:55:05 -0600
Subject: [PATCH] style: re-indent script, rename vars, remove cruft

---
 .../js/modules/setTargetForExternalLinks.js   | 36 +++++++++----------
 1 file changed, 16 insertions(+), 20 deletions(-)

diff --git a/taccsite_cms/static/site_cms/js/modules/setTargetForExternalLinks.js b/taccsite_cms/static/site_cms/js/modules/setTargetForExternalLinks.js
index efe4ea945..028e8e113 100644
--- a/taccsite_cms/static/site_cms/js/modules/setTargetForExternalLinks.js
+++ b/taccsite_cms/static/site_cms/js/modules/setTargetForExternalLinks.js
@@ -9,31 +9,27 @@ const SHOULD_DEBUG = window.DEBUG;
  */
 export default function findLinksAndSetTargets() {
   const links = document.getElementsByTagName('a');
-  const baseDocumentHost = document.location.host;
-  const baseDocumentHostWithSubdomain= `www.${baseDocumentHost}`;
+  const baseDocHost = document.location.host;
+  const baseDocHostWithSubdomain= `www.${baseDocHost}`;
 
   [ ...links ].forEach( function setTarget(link) {
-      if ( ! link.href) {
-        return false;
-      }
-
-      const isMailto = (link.href.indexOf('mailto:') === 0);
+    if ( ! link.href) {
+      return false;
+    }
 
-      const isInternalLink = link.host === baseDocumentHost || link.host === baseDocumentHostWithSubdomain
+    const isMailto = ( link.href.indexOf('mailto:') === 0 );
+    const isSameHost = link.host === baseDocHost || link.host === baseDocHostWithSubdomain
 
-      if (!isInternalLink || isMailto ) {
-        if (link.target !== '_blank') {
-          link.target = '_blank';
-          if (SHOULD_DEBUG) {
-            console.debug(`Link ${link.href} now opens in new tab`);
-          }
-        }
-        if (link.target === '_blank') {
-          link.setAttribute('aria-description', 'Opens in new window.');
-        }
-        if (typeof setTargetCallback === 'function') {
-          setTargetCallback( link );
+    if ( ! isSameHost || isMailto ) {
+      if ( link.target !== '_blank') {
+        link.target = '_blank';
+        if (SHOULD_DEBUG) {
+          console.debug(`Link ${link.href} now opens in new tab`);
         }
       }
+      if ( link.target === '_blank') {
+        link.setAttribute('aria-description', 'Opens in new window.');
+      }
+    }
   });
 }