Sprint5 b03528 reorder tabs by role #100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perform access control in the controller and present a list of columns for renderring such than an ng-repeat can be used:
`<wvr-tab ng-repeat="column in columns" path="{{column.path}}" view="views/management/{{column.view}}.html" label="{{column.label}}">{{column.label}}</wvr-tab>`
This is not working as expected, possibly due to the current weaver tabs implementation.
This includes a not so great work-around using ng-show with a preset number of columns.
This should be improved to use ng-repeat or something similar instead of using ng-show with a preset column list.
'for of' is available in ES6.
Pull Request Test Coverage Report for Build 67
💛 - Coveralls |
Contributor
Author
|
There are plans to come back to this PR and re-consider its design and possibly pulling this in at a later date. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-orders tabs based on current role.
The use of
ng-repeatis preferred but the current design ofwvr-tabsprevents this from working as expected.ng-showis used instead.The routing had to be changed for the default tab to be properly selected.