Skip to content

alternative management service sort #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

alternative management service sort #93

wants to merge 2 commits into from

Conversation

@ghost
Copy link

@ghost ghost commented Jun 21, 2018 •
edited by ghost
Loading

This pull request is for comparison. Simply applied weaver table directive to services for management.

alternative for #91

@ghost ghost requested review from kaladay and rladdusaw June 21, 2018 03:58
@ghost ghost changed the title Sprint5 b03526 alternative management service sort alternative management service sort Jun 21, 2018
@ghost ghost mentioned this pull request Jun 21, 2018
Closed
@coveralls
Copy link

coveralls commented Jun 21, 2018

Pull Request Test Coverage Report for Build 35

  • 5 of 27 (18.52%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 12.054%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/controllers/serviceController.js 4 5 80.0%
app/directives/weaverTableDirective.js 0 1 0.0%
app/repo/serviceRepo.js 1 21 4.76%
Totals Coverage Status
Change from base Build 17: -0.2%
Covered Lines: 169
Relevant Lines: 1175
💛 - Coveralls

@rladdusaw
Copy link
Contributor

rladdusaw commented Jun 22, 2018

Using improved PR #97

@rladdusaw rladdusaw closed this Jun 22, 2018
@rladdusaw rladdusaw deleted the sprint5-b03526-alternative-management-service-sort branch June 22, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rladdusaw rladdusaw Awaiting requested review from rladdusaw

@kaladay kaladay Awaiting requested review from kaladay

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coveralls @rladdusaw @tamu-sad-iii