Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jun 22, 2018

Here is how ng-tables allows for custom headers. In addition, refactored weaverTableConfig to weaverTable to add directive functions to share with parent scope and added repo to it to simplify the directive scope even more.

I vote for these changes.

@ghost ghost requested a review from rladdusaw June 22, 2018 00:58
@coveralls
Copy link

Pull Request Test Coverage Report for Build 57

  • 19 of 118 (16.1%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 12.046%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/controllers/abstractIdeaController.js 0 3 0.0%
app/controllers/serviceController.js 15 18 83.33%
app/controllers/noteController.js 1 15 6.67%
app/controllers/featureProposalController.js 1 16 6.25%
app/controllers/ideaController.js 1 25 4.0%
app/directives/weaverTableDirective.js 1 41 2.44%
Files with Coverage Reduction New Missed Lines %
app/directives/weaverTableDirective.js 1 1.27%
Totals Coverage Status
Change from base Build 51: 0.1%
Covered Lines: 169
Relevant Lines: 1178

💛 - Coveralls

@ghost ghost requested a review from jeremythuff June 22, 2018 01:07
@rladdusaw rladdusaw merged commit 67c4ded into sprint5-b03526-isolated-scope-directive-sorting-services Jun 22, 2018
@ghost ghost deleted the sprint5-b03526-isolated-scope-directive-sorting-services-improvements branch June 22, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants