From 3a75c4eecba6f001eaf4831ba1a1ccdf113fe795 Mon Sep 17 00:00:00 2001 From: Kevin Day Date: Thu, 1 Oct 2020 13:58:11 -0500 Subject: [PATCH 1/2] Issue 80: On "Active Sprints" board show icon for Milestone or Project depending on how the Sprint is populated The crafted icons are added any each reasonable location, helping improve usability via the icon as hints. This includes icons for all known ServiceTypes. This also fixes the management board, thereby allowing for the remote project management icons being displayed in this case as well. --- app/controllers/productController.js | 22 ++++++++++ app/directives/remoteProjectsIconDirective.js | 34 +++++++++++++++ app/index.html | 1 + app/resources/images/github-milestone.png | Bin 0 -> 1639 bytes app/resources/images/github-project.png | Bin 0 -> 1065 bytes app/resources/images/versionone.png | Bin 0 -> 3545 bytes .../styles/sass/directives/_all.scss | 3 +- .../sass/directives/_remoteProjectsIcon.scss | 5 +++ .../styles/sass/management/_products.scss | 21 ++++++++- app/views/directives/remoteProjectsIcon.html | 3 ++ app/views/home.html | 12 +++++- app/views/management/products.html | 19 +++++++-- .../management/remoteProjectManager.html | 5 ++- app/views/modals/addProductModal.html | 8 +++- app/views/modals/editProductModal.html | 8 +++- tests/mock/model/mockProduct.js | 8 ++-- .../unit/controllers/productControllerTest.js | 23 ++++++++++ .../directives/remoteProjectsIconDirective.js | 40 ++++++++++++++++++ 18 files changed, 196 insertions(+), 16 deletions(-) create mode 100644 app/directives/remoteProjectsIconDirective.js create mode 100644 app/resources/images/github-milestone.png create mode 100644 app/resources/images/github-project.png create mode 100644 app/resources/images/versionone.png create mode 100644 app/resources/styles/sass/directives/_remoteProjectsIcon.scss create mode 100644 app/views/directives/remoteProjectsIcon.html create mode 100644 tests/unit/directives/remoteProjectsIconDirective.js diff --git a/app/controllers/productController.js b/app/controllers/productController.js index 72866b4..384e2cc 100644 --- a/app/controllers/productController.js +++ b/app/controllers/productController.js @@ -123,6 +123,28 @@ app.controller('ProductController', function ($controller, $scope, ApiResponseAc $scope.otherUrlsChanged = true; }; + $scope.distinctRemoteProjectManagers = function (remoteProjectInfo) { + var list = []; + var matched = false; + + for (var i in remoteProjectInfo) { + matched = false; + + for (var j in list) { + if (remoteProjectInfo[i].remoteProjectManager.id === list[j].remoteProjectManager.id) { + matched = true; + break; + } + } + + if (!matched) { + list.push(remoteProjectInfo[i]); + } + } + + return list; + }; + if ($scope.isManager() || $scope.isAdmin()) { $scope.remoteProjectManagers = RemoteProjectManagerRepo.getAll(); diff --git a/app/directives/remoteProjectsIconDirective.js b/app/directives/remoteProjectsIconDirective.js new file mode 100644 index 0000000..23e1105 --- /dev/null +++ b/app/directives/remoteProjectsIconDirective.js @@ -0,0 +1,34 @@ +app.directive('remoteProjectsIcon', function ($controller) { + return { + templateUrl: 'views/directives/remoteProjectsIcon.html', + restrict: 'E', + scope: { + type: '@', + width: '@', + height: '@' + }, + link: function ($scope, element, attr) { + $scope.typeIcon = false; + $scope.tooltip = ""; + + if ($scope.type === 'GITHUB_MILESTONE') { + $scope.typeIcon = 'github-milestone.png'; + $scope.tooltip = "Github Milestone"; + } else if ($scope.type === 'GITHUB_PROJECT') { + $scope.typeIcon = 'github-project.png'; + $scope.tooltip = "Github Project"; + } else if ($scope.type === 'VERSION_ONE') { + $scope.typeIcon = 'versionone.png'; + $scope.tooltip = "Versione One"; + } + + if (angular.isUndefined($scope.width)) { + $scope.width = "16"; + } + + if (angular.isUndefined($scope.height)) { + $scope.height = "16"; + } + } + }; +}); diff --git a/app/index.html b/app/index.html index d151a9b..fff9714 100644 --- a/app/index.html +++ b/app/index.html @@ -193,6 +193,7 @@ + diff --git a/app/resources/images/github-milestone.png b/app/resources/images/github-milestone.png new file mode 100644 index 0000000000000000000000000000000000000000..1ae3fab28708ee088b3a1769f3ac8c5c0d8f46c5 GIT binary patch literal 1639 zcmV-t2AKJYP){LYK~#90?V5jx6jdC+KX2CEbHzRG_N^!AKbKMjX<!H?CkCBo!Y2@@d=nYb7l%iG-X(AL@70YXlUq-M%#~1Ksud{ z>`*QvPv>&E`xLpUjXT#WYUz~D2 zlhwH*NTpI6fa5;uSF+jctwC*h^MGM$Bf&n?H1C?k#ysF&PuWkvw?PL1^Z;u-WoLjL zehs?2yXP5(aRAVTz~7Zp3oXmKP_JXR4?qZEE2X>>P;Uj?47}zkI|f)4AHGV({(a09K2Dm*${k{hJz_P3@z;2yR zDfM73ms?rShWFxhkswTR^p8vK57_1wV7{h(5L7amd>lBdRVwvfE|Hy z4LIz`4*}Byv~lnKn($VS!NI|TQfdwQKX1BHY6p<=Ywx`{T__B@1-4f@2Og+XcPg;L zk&gifL-qxLWm(@TrQY^YFOpJj@@w1dEda0+7;)s)b?V;FL{^s%*-sUgWo-lw_^6+g zQfebv)dUD3bQ2JE1)Kx+IPy})9HJln&i5!|SzHuG48vFj3~6)*kk4c?Ih|shCPsmL zr8)4ZPo3Go-HyB$A4e93LZNU1*x;j{)zQ(h9Z&8P#0fTXi@Y27+mY9JJ9Svi#P-TJ z(1#Y&H1oh`I-OGL9x3Hh?y?|0ppg|Y>KcS!PEd*c7Vu>QefVPA_Ie@2Ngwr_U0q!_ zRel7C0*yW-`N$=Eo#Ac3^^W{0aH+vQw3JGv^R{iTV(gFb(ve6cw&AQwuM=!W7_9IM z@UtVYpgJe$cggt%?N5qjSw8|V`=}R4DHlPl6KvKNsE~KQ-8n%TSnkM2fkP4O*F*b^ z!=ZKs=o$ziqC6)YU}AY!w!w0s%aK2hV0%)el#7KBFZrkso2GdXnx6`LF{#Z7`kmjS zj3rG?XU2>f(}C?usia1I$uNwyICrY8iUMx(&bI(w0Pb{te+>*qw5`Rq?e~Feebmnv z3WbVqYRSETmpx2e=vtS(d_=oiq?CQYBRZWBVy|hM@4Cx^q{30p3Pu?Vb#6@HtB7`M z=;`U13vBUGpA$liFZ~LwN`<|6o!w5F9Q%PO<#PEGKzFEX1AT=;p=QfX(Ny%(j0rdb z%wZxWKGy`BRY)mc1^ga{ZZ=Kxd!3^01T=Urpu;aUjZ7|=TcVVD#z%d~G|dEvdV71P8ip}|=Hh`-+qV0HTs+in0o_T?75CD_(9qCZ zz>PlYO_pWt4{FOh0lFw4Iy*bFLWrQpTrDM$NGt=^`Kb4qruljpd%Cm1no7xJvJl4T zWuj!;w%-AXFID^7w(YC=HJQgsrP5zv8wJS&t_D6ZP4kOJ8hSnaAJNCsc8;dg=}>Ql zxT%@|!!X_f0)>w&gbTK9uRMMFwC?4uK-3&q^z`)1Etkvdgb=+^M%HR<+x|0=NNjaZ lgJNQ0Vq#)qVq#)K@*h5-yx-wWHPrwB002ovPDHLkV1mm3#D{1 zl}fz_ehSbut&~#w6@Z&-GW+;0Ns{O0=H{CW0GUk2gW~z}0PrT8%~k?{%sUBh3jXT7 zy}cM8AGb4$Wvs5QVtac#?^r=Ya;`X%59;2nTBjsV^Pcw@=U zPc#}Wc-hGt!tF*`Ss64)xvolM2*tP-EbsarDJ$c9O z?(UFCB(T4~kB5f`)A+^31qKEN5Q#)kQ&YneO3WYE~KaZ=c ztDLd(^K;D1%wT0@g=sFKmVlxtn4Fx%;o%|L+uKd!p->1XCnrpM3MJr)>gsBQ!(k|j zl2a#yU}Iy0X)hrK06fR>gPQ_V08WV2aj zJ%koeT3TwV5khc(f6uIk&;o96Z%s9~+YMD!ne`A_z|ql>spj>1AxTo6vtNeL0>a_2 zsix~X(;mVK*xlXDE1<8hk7*wv1soqAV|aKNgpi!Nq9_<09c9`}C;_op470Pd=u z<>jSme0q8sKA(?iPun&_>+9<{I5;rXDWxzB1BpZe*Voqt=XZ8?Vqsx{c`n-o#N% zyxh`$wh0&+8Nt-lRNgT~QBYA)0guOny1F{MA_1^bKz)5Z^J_Q@g#Hh(14jVw0K9Po z@D9KmM*!~tym18Z4!|2n0Pg_2DS82xY=%@-MPp-QPR-8uex8FR0s?^m0)c=PAI+Si zUjmK*-T`>y2;d!nH$^W%0)WcON}tQ+%6V#`s;aQp?&o3{2GZ$tPK^-aGYsQX!TW%8 zI>t8j%6O<#J_s2eBJjmNURl0m)?YGk_@9MD`L*CX-))-?zeqQaU6_(gy(MSF>Ih jX8_&;Apbkjp&0l9HwF9~mpIDg00000NkvXXu0mjfM-|mr literal 0 HcmV?d00001 diff --git a/app/resources/images/versionone.png b/app/resources/images/versionone.png new file mode 100644 index 0000000000000000000000000000000000000000..1082c62695d87bdcef55c300d799a8f615a68efe GIT binary patch literal 3545 zcmV;~4JPu5P)~Bu5*P=GffZhqhFN3awQ*E#B)*>re|=Z8h39N}i~Xhi09kE zrcIl|+uPf7%x3cvo6WWuK(gI#R{~H1kOHs*7zbct7^YVw67@(VlFP}-$(^T8of@9+ z_?Y>)1s-_dfuy0Kq4id)^*`)(`!WPZG_frEy+|ZFrBEo2bai!|3wE495DD17f4{i8 zy1K}0Hvf@`asV*FusaKeVJ=G~l7spA`R~5_?z=aFW_PXx{E~Q?*=+tZ5hVmGFn3@W zW>g}P{C9qS{@;T^#GD97NlD2WA0OXML`%KZ6^q4)iHSi{QW6#}T!_%nP=thpz-F^y za&i)5V`I?ibkON^uvjeK180~)xm^Bdy3D~)FXUMKyyZ&aiTK@zOT|F%= z4S9KaSh;c~GBYy~5)$Iow#{b4g$ozZ-rkOrCr{$+*|V_Q?QZLfM50f!v$LOTX=xep zHxD2H0+uaXmU#8*)dnKUa8)jo$*^I=29%bTA}uW~keGPr@9#%bQxgsxIDnB6*Euo_ zGY}CGv9YVGtKDDwei4wGnwmW}Hr5OvLRc0O5`xW}H>13~9CzJym%nj%#q{(v>g(%K zQ&WSnu`yRwZpvh`KVH3h^{_v7eI_6&Dd|6rMq?uYxv*^Y>eYDbt+$YnFz;g^#>U1_ zU0sd(`g#zNu$ZJ$=}Q9x18@6k&nE&B6B8eqoSggzfCY|vsZ@%}%1S)<+;d=)Tk;^X533Od+OC=_UHY{Y{P zJ}4{-85tRAC@LyadTQ_X7Ko0H-fFQ}b~@@JA|i0�e~3ym)R=&jThVCQwjNfFFMN zfu|RVM2CllhMsZP&Lsg^Sy_wpdi{3*!e(_W%c8Nd5vy0P1^`$r7MM&Xu8mkMMtFGm z+%v(gWE>|y;o;#Bi@mR>`uh5io0|)x(a6(>hll^Zx3{;=Wg{Yz3V)H2ksqm4Dsuc) zS67oGdV70`VHg5H07$7+($v%x%@rdfBP5kdIlD5Mj0^^Y&+VI=n@JeETCMJ?s;UZe zm8%m0X=!O$DwWFaXdo*qi)LnKoSZ%U@WWi70H~>{Y0d=f+O>;kv$V9-ZyRN0Wlki- z#KdeSUkK1>G#?8ax3#sobW~eg%L_I?KR>{Xm4aqZeQij9pG_5$6$ zefvVm69MVz>1isJ%I4Vcsi&TD>*&Uf8>CPuxL{e9rT+f@fD$Jn`ugjydCAAe$CJ%w z3&_@v9Xp(QL2PVnDG3PRJqCw|hc`m-XxzSiyW2rWE|;UIsECv8b~_px8axbBo^j~V zA)Z`TRtA<0Y}>NDyc{x_jHff3%^RI6&N89ZY8R;0>V8MYa&vRNGTqV9!MkcHDJf*P z+x@;`Gcz-!QmHsQ48xF4r}Nv6BerkfF6;%?l`B`qlB*t2US6IgsUw=1op6DJel{XsFNaJ>j8;9ulhV*s)^=HTe0nf=cK00~Ba0Dh0a5{U$*rKOx~ zx7(ertSbn6%CpZt>$0BFXoSIFa9ZeigGeMoY-}t~$1n^xGO_?*v)OpdIH^?XG>Py9 z!r%`bI^=5Kj)U23Mq^_mCyT{ml$4YJ0NUHz@x~i(ps=tI(b3URDwT+ch~QSE{@{)~ z?%>IGyPaF*iUEL#cm#xng&`2!d+)u-%*@2ObGMH1dU|@$+1crKKy7YrhQVOq;&!-ZZvoz7TO<+%>`XX-z4zXGZtHq__Q%J^qqw*j zH8nNRYPG1Ss0cVF;a&nc?tu`IG%70U6~Uq*;OFl6_&9}zhH}qzg+k%-nSSlsH4=$L zTs@6OLl%q0t=(5%d4&K_Mn;C;F+KkH~v$z^3_0sHfYfq?;@?3gbL0O8@`J;Fv;u3QP&p>QGd*=L_Yuh(;OXJ;q6y1FmMjU_pC^otj`9Xt0AN|RoBIy{k3II-6#%>=SmExfKVTRJPe1)MCle9s>+3nW zwzig6KbSK=AsmUGg-j;nE;tJSZ@&5FG{Z2wOWxVpIVZ=$&5YXGS`ZPYr>F7ZhaWly z<7(L&G<0-y2vxRa%a(mVD{v9AEZgQ->x(bG2zVd_Zav0Uty;y&dc7WJ&YZ!qW5+N) zKF;aau3hUiQ3)o_oH@gj8HV}h@ZrPUbdn=r!GZ;+9V;4*MtuJH=W}xIYECd8>wb6m z`RAXxN!ctU5{cGP<_JhnPd^1<#<8%escB9DJo)64P%3{tnQClogjV~j|Ad4DUM~qY zjvYJZ)Qc4g#s50W904sYEe4ilKXEKkdN(&=zCHa7OZrl+U>$5B^YT#VhjcLyBM+i$;(s;VlUZtvc`9v^>NtrmOs z?BV2#7cZi#s|$DDc_$uy^ifW~eED*0+qR9@cK`nUcf1_lNwF)>lN5jvfbk&!ISm58J+ zkH_QU;{Gr-HFd;M7Znu+tyYVO2&Wgs<^_7a9_P=W_gXI|CI&e3ZXJ<-B0O7Lw{9I-t=8Mv5Bx)AWu>d5@!pqTepyLw@^ni; zR#sMmN~IbW8r-^dYd}X|^Nn}jdB-Vvl}dFpB_$=7+~i1}2p}S9LPA2J@Ld6wN=2`~ z{`$WZ2_Jm$0YyeeIuQ^Z9sL*bkRN#?fQY0E7cQ)J!7No&RCwIMxn0=3dpD`oYNz-# z8qGhnTI~XwD*-({Js}#6=71{_3JVMAr=Nbh{aF*y)YKGh*|Nn|wtZ<br!)!^7CKXAf#?Yh7({0svT+t$X2x7q-0g(n~WgE4V>GA50`AB|SVj zIax=7w@5jo41>(fOcWIrAulfv8jZ$Z7nqosfL5!;(W6J9)oOXC#{x{rK)M_=9N+slSIZP%KOePaX zM@OO4>CoNXjq~TvpRzI^#iXJ=;ce^Jum7sDveNr^bOB=C z2ylg+J9mcE)zu~5ym?b$u~_5)?qpfkD3wZ05{YCoD=SMM%&$Uy!EGhrUlIQVP%dQ1 Te~FgL00000NkvXXu0mjfDP6>8 literal 0 HcmV?d00001 diff --git a/app/resources/styles/sass/directives/_all.scss b/app/resources/styles/sass/directives/_all.scss index 9f69db6..53f607f 100644 --- a/app/resources/styles/sass/directives/_all.scss +++ b/app/resources/styles/sass/directives/_all.scss @@ -1,2 +1,3 @@ @import "header"; -@import "footer"; \ No newline at end of file +@import "footer"; +@import "remoteProjectsIcon"; diff --git a/app/resources/styles/sass/directives/_remoteProjectsIcon.scss b/app/resources/styles/sass/directives/_remoteProjectsIcon.scss new file mode 100644 index 0000000..c07e6f0 --- /dev/null +++ b/app/resources/styles/sass/directives/_remoteProjectsIcon.scss @@ -0,0 +1,5 @@ +.remote-product-icon { + display: inline-block; + position: relative; + top: 0px; +} diff --git a/app/resources/styles/sass/management/_products.scss b/app/resources/styles/sass/management/_products.scss index 1b541b6..e69a642 100644 --- a/app/resources/styles/sass/management/_products.scss +++ b/app/resources/styles/sass/management/_products.scss @@ -2,6 +2,20 @@ cursor: pointer; } +.management-table { + .product-table { + .product-rpm-row { + clear: both; + } + } +} + +.product-rpm-icons { + .remote-product-icon { + padding: 0px 3px; + } +} + .remote-product-panel { margin-top: 20px; @@ -20,4 +34,9 @@ ul { margin-bottom: 0; } -} \ No newline at end of file + + .remote-product-icon { + top: -4px; + padding-right: 6px; + } +} diff --git a/app/views/directives/remoteProjectsIcon.html b/app/views/directives/remoteProjectsIcon.html new file mode 100644 index 0000000..c6e7262 --- /dev/null +++ b/app/views/directives/remoteProjectsIcon.html @@ -0,0 +1,3 @@ + + + diff --git a/app/views/home.html b/app/views/home.html index 13d0ee5..fe232f4 100644 --- a/app/views/home.html +++ b/app/views/home.html @@ -34,7 +34,10 @@ {{sprint.id}} {{sprint.name}} - {{sprint.product}} + + + {{sprint.product}} + {{sprint.cards.length}} {{getSprintEstimateTotal(sprint)}} @@ -102,7 +105,12 @@ Internal Count - {{product.name}} + + + + + {{product.name}} + {{product.stats.backlogItemCount}} {{product.stats.featureCount}} {{product.stats.defectCount}} diff --git a/app/views/management/products.html b/app/views/management/products.html index f9e4822..0852dda 100644 --- a/app/views/management/products.html +++ b/app/views/management/products.html @@ -15,9 +15,22 @@ {{product.name}} - {{product.remoteProjectManager.name}} - {{product.remoteProject.name}} - {{product.scopeId}} + +
+ + {{rpi.remoteProjectManager.name}} +
+ + +
+
{{getRemoteProjectByRemoteProjectInfo(rpi).name}}
+
+ + +
+
{{rpi.scopeId}}
+
+ diff --git a/app/views/management/remoteProjectManager.html b/app/views/management/remoteProjectManager.html index d6d3202..b325422 100644 --- a/app/views/management/remoteProjectManager.html +++ b/app/views/management/remoteProjectManager.html @@ -10,7 +10,10 @@ Actions - {{remoteProjectManager.name}} + + + {{remoteProjectManager.name}} + {{remoteProjectManager.url}} diff --git a/app/views/modals/addProductModal.html b/app/views/modals/addProductModal.html index 472c014..ced4b05 100644 --- a/app/views/modals/addProductModal.html +++ b/app/views/modals/addProductModal.html @@ -38,8 +38,12 @@

Create Product

    -
  • {{getRemoteProjectByRemoteProjectInfo(remoteProject).name}} - +
  • + {{getRemoteProjectByRemoteProjectInfo(remoteProject).name}} + + + +
diff --git a/app/views/modals/editProductModal.html b/app/views/modals/editProductModal.html index 9798f75..6a6651e 100644 --- a/app/views/modals/editProductModal.html +++ b/app/views/modals/editProductModal.html @@ -39,8 +39,12 @@

Edit Product

    -
  • {{getRemoteProjectByRemoteProjectInfo(remoteProject).name}} - +
  • + {{getRemoteProjectByRemoteProjectInfo(remoteProject).name}} + + + +
diff --git a/tests/mock/model/mockProduct.js b/tests/mock/model/mockProduct.js index d17ce81..513eb29 100644 --- a/tests/mock/model/mockProduct.js +++ b/tests/mock/model/mockProduct.js @@ -5,7 +5,7 @@ var dataProduct1 = { remoteProjectManager: { id: 1, name: "Remote Project Manager 1", - type: "VERSION_ONE", + type: "GITHUB_MILESTONE", url: "url1", token: "username1:password1" }, @@ -18,8 +18,8 @@ var dataProduct2 = { name: "Product 2", remoteProjectInfo: [{ remoteProjectManager: { - id: 1, - name: "Remote Project Manager 1", + id: 2, + name: "Remote Project Manager 2", type: "VERSION_ONE", url: "url2", token: "username2:password2" @@ -35,7 +35,7 @@ var dataProduct3 = { remoteProjectManager: { id: 1, name: "Remote Project Manager 1", - type: "VERSION_ONE", + type: "GITHUB_MILESTONE", url: "url1", token: "username1:password1" }, diff --git a/tests/unit/controllers/productControllerTest.js b/tests/unit/controllers/productControllerTest.js index 06ef2de..6d25612 100644 --- a/tests/unit/controllers/productControllerTest.js +++ b/tests/unit/controllers/productControllerTest.js @@ -99,6 +99,7 @@ describe("controller: ProductController", function () { "confirmDeleteProduct", "createProduct", "deleteProduct", + "distinctRemoteProjectManagers", "editProduct", "getRemoteProjectByRemoteProjectInfo", "getRemoteProjectManagerRemoteProjects", @@ -208,6 +209,28 @@ describe("controller: ProductController", function () { expect($scope.cancelDeleteProduct).toHaveBeenCalled(); }); + it("distinctRemoteProjectManagers should return a distinct list", function () { + var response; + var rpis = [ + { + scopeId: "0010", + remoteProjectManager: dataRemoteProjectManager1 + }, + { + scopeId: "0020", + remoteProjectManager: dataRemoteProjectManager2 + }, + { + scopeId: "0030", + remoteProjectManager: dataRemoteProjectManager1 + } + ] + + response = $scope.distinctRemoteProjectManagers(rpis); + + expect(response.length).toEqual(2); + }); + it("editProduct set the productToEdit and open the modal", function () { spyOn($scope, "openModal"); diff --git a/tests/unit/directives/remoteProjectsIconDirective.js b/tests/unit/directives/remoteProjectsIconDirective.js new file mode 100644 index 0000000..cab5570 --- /dev/null +++ b/tests/unit/directives/remoteProjectsIconDirective.js @@ -0,0 +1,40 @@ +describe("directive: remoteProjectsIcon", function () { + var $compile, $q, $scope, directive, element; + + var initializeVariables = function () { + inject(function (_$q_, _$compile_) { + $q = _$q_; + $compile = _$compile_; + }); + }; + + var initializeDirective = function (settings) { + inject(function (_$rootScope_) { + $scope = _$rootScope_.$new(); + + var attr = settings && settings.attr ? settings.attr : "type=\"GITHUB_MILESTONE\""; + var body = settings && settings.body ? settings.body : ""; + + element = angular.element("" + body + ""); + directive = $compile(element)($scope); + + $scope.$digest(); + }); + }; + + beforeEach(function () { + module("core"); + module("app"); + module("templates"); + + installPromiseMatchers(); + initializeVariables(); + }); + + describe("Is the directive", function () { + it("defined", function () { + initializeDirective(); + expect(directive).toBeDefined(); + }); + }); +}); From 6ded475c04d9c8de6c97a0d526ecb1c0939fa934 Mon Sep 17 00:00:00 2001 From: Kevin Day Date: Thu, 1 Oct 2020 14:10:23 -0500 Subject: [PATCH 2/2] Increase coverage with directive tests. --- .../directives/remoteProjectsIconDirective.js | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/tests/unit/directives/remoteProjectsIconDirective.js b/tests/unit/directives/remoteProjectsIconDirective.js index cab5570..a783637 100644 --- a/tests/unit/directives/remoteProjectsIconDirective.js +++ b/tests/unit/directives/remoteProjectsIconDirective.js @@ -12,7 +12,7 @@ describe("directive: remoteProjectsIcon", function () { inject(function (_$rootScope_) { $scope = _$rootScope_.$new(); - var attr = settings && settings.attr ? settings.attr : "type=\"GITHUB_MILESTONE\""; + var attr = settings && settings.attr ? settings.attr : ""; var body = settings && settings.body ? settings.body : ""; element = angular.element("" + body + ""); @@ -36,5 +36,20 @@ describe("directive: remoteProjectsIcon", function () { initializeDirective(); expect(directive).toBeDefined(); }); + + it("defined using GITHUB_MILESTONE", function () { + initializeDirective({attr: "type=\"GITHUB_MILESTONE\""}); + expect(directive).toBeDefined(); + }); + + it("defined using GITHUB_PROJECT", function () { + initializeDirective({attr: "type=\"GITHUB_PROJECT\""}); + expect(directive).toBeDefined(); + }); + + it("defined using VERSION_ONE", function () { + initializeDirective({attr: "type=\"VERSION_ONE\""}); + expect(directive).toBeDefined(); + }); }); });