[Issue 211] Researcher Age Visualization #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered consumer is triggered an additional time more than expected.
Will have to be updated with i18n keys as well as labels provided to d3.
ghost
requested a review
from 
ghost
linked an issue
rmathew1011
approved these changes
Jul 10, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to TAMULib/scholars-discovery#314
Two new components added: BarplotComponent and ResearchAgeComponent. With ResearchAgeComponent using BarplotComponent in its template.
ResearchAgeComponent has response routing with multiple observables of researchAge state from the store in which barplot observes which response. Multiple requests are issued asynchronously. Note, the store overwrites researchAge state after receiving response. This could be considered a bad central state practice to not have all information in the state to represent the contextualized view. However, with interactions and potentially large number of requests/responses required to construct a graph, it seems appropriate to use the SVG as its state and not additionally in the redux store.