Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking between co-author and co-investigator network #325

Merged
merged 7 commits into from
Jun 11, 2024

Conversation

wwelling
Copy link

@wwelling wwelling commented Jun 10, 2024

This PR resolves #318 and #320. The child component ChordDiagramComponent was not reinitializing due to the expected behavior of Angular to optimize by not reinitializing multiple uses of the same component within a certain context.

There are still issues if the data network does not return any results. That will be addressed in a subsequent PR to address issue #324.

@wwelling wwelling requested a review from qtamu June 10, 2024 22:13
@wwelling wwelling changed the title June sprint issue 318 Fix linking between co-author and co-investigator network Jun 10, 2024
@wwelling wwelling merged commit b1d13de into june-sprint-staging Jun 11, 2024
18 checks passed
@wwelling wwelling mentioned this pull request Jul 10, 2024
@wwelling wwelling deleted the june-sprint-issue-318 branch July 23, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants