From 57fd6051e957a2fa4c33a63c5d06bf07b9bac321 Mon Sep 17 00:00:00 2001 From: feos Date: Fri, 21 Sep 2018 23:31:46 +0300 Subject: [PATCH] fix #1246 the easy way --- BizHawk.Client.EmuHawk/movie/PlayMovie.cs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/BizHawk.Client.EmuHawk/movie/PlayMovie.cs b/BizHawk.Client.EmuHawk/movie/PlayMovie.cs index fa4131d5a7..62f072f5e9 100644 --- a/BizHawk.Client.EmuHawk/movie/PlayMovie.cs +++ b/BizHawk.Client.EmuHawk/movie/PlayMovie.cs @@ -479,7 +479,13 @@ private void MovieView_SelectedIndexChanged(object sender, EventArgs e) } break; case HeaderKeys.PLATFORM: - if (kvp.Value != Global.Game.System) + // feos: previously it was compared against Global.Game.System, but when the movie is created + // its platform is copied from Global.Emulator.SystemId, see PopulateWithDefaultHeaderValues() + // the problem is that for GameGear and SG100, those mismatch, resulting in false positive here + // I have a patch to make GG and SG appear as platforms in movie header (issue #1246) + // but even with it, for all the old movies, this false positive would have to be worked around anyway + // TODO: actually check header flags like "IsGGMode" and "IsSegaCDMode" (those are never parsed by bizhawk) + if (kvp.Value != Global.Emulator.SystemId) { item.BackColor = Color.Pink; }