Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCEHawk now blinks constantly while unthrottled (Doesn't happen in 2.2.2) #1333

Closed
Sonia-7 opened this issue Sep 21, 2018 · 5 comments
Closed

PCEHawk now blinks constantly while unthrottled (Doesn't happen in 2.2.2) #1333

Sonia-7 opened this issue Sep 21, 2018 · 5 comments
Labels
Core: PCEHawk (Alt.) PC Engine (PCE) / TurboGrafx-16 (TG-16) / SuperGrafx core Repro: Fixed/added as of 2.3/2.3.1/2.3.2 (2.3.3 has its own label) Repro: Regression from 2.2.x (2.2, 2.2.1, or 2.2.2)

Comments

@Sonia-7
Copy link

Sonia-7 commented Sep 21, 2018

Pressing Turbo (or Toggle Throttle) now causes PCEHawk to blink/flicker constantly as of version 2.3.

Steps to reproduce:

  1. Load any PCE game.
  2. Press Turbo (default key combo is Shift+Tab), or Toggle Throttle.
  3. Watch as the game flickers repeatedly.

This doesn't happen in 2.2.2 or any version under it.

And yes, already tested in the latest dev build (2018-09-19 as of the time of this post). Still the same.
@Asnivor Asnivor added Bug (GoogleCode) Grandfathered label from GoogleCode. Use the other bug labels. Core: PCEHawk (Alt.) PC Engine (PCE) / TurboGrafx-16 (TG-16) / SuperGrafx core labels Sep 21, 2018
@Asnivor
Copy link
Contributor

Asnivor commented Sep 25, 2018

Bisect shows that it is this commit again:

aa7cee1

@alyosha-tas
Copy link
Contributor

I honestly can't remember what that commit does. You can try reverting it if you want.

@Asnivor
Copy link
Contributor

Asnivor commented Sep 26, 2018

I've done the revert locally and tested and it appears to have fixed all the issues caused.

I'll push to master and ask users to test in the other tickets

Asnivor added a commit that referenced this issue Sep 26, 2018
@Asnivor
PCE: Revert aa7cee1. This looks to resolve the following: #1333 #1303 #…
4a2d9dd 
…1287 #1231 #1203 and *maybe* #1266
@Asnivor
Copy link
Contributor

Asnivor commented Sep 26, 2018

@synnae This looks OK to me know. Please test in the latest dev build:

https://ci.appveyor.com/project/zeromus/bizhawk-udexo/build/artifacts

@Sonia-7
Copy link
Author

Sonia-7 commented Sep 26, 2018

@Asnivor I tested it and everything seems fine now. Thanks for the fix!

@Sonia-7 Sonia-7 closed this as completed Sep 26, 2018
@YoshiRulz YoshiRulz added Repro: Regression from 2.2.x (2.2, 2.2.1, or 2.2.2) Repro: Fixed/added as of 2.3/2.3.1/2.3.2 (2.3.3 has its own label) and removed Bug (GoogleCode) Grandfathered label from GoogleCode. Use the other bug labels. labels Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core: PCEHawk (Alt.) PC Engine (PCE) / TurboGrafx-16 (TG-16) / SuperGrafx core Repro: Fixed/added as of 2.3/2.3.1/2.3.2 (2.3.3 has its own label) Repro: Regression from 2.2.x (2.2, 2.2.1, or 2.2.2)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Asnivor @YoshiRulz @alyosha-tas @Sonia-7