Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to poke more than 500 bytes above 0x4020 in the NESHawk System Bus #1127

Closed
NarryG opened this issue Mar 7, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@NarryG
Copy link
Contributor

commented Mar 7, 2018

NESHawk uses game genie cheats when poking any address above 0x4020
else { ApplyGameGenie(addr, value, null); //Apply a cheat to the remaining regions since they have no direct access, this may not be the best way to handle this situation }
There's a hard limit on the number of cheats applied through ApplyGameGenie()
public int[] cheat_indexes = new int[500];

Could this limit be raised to allow for more than 500? I don't see any real reason to limit it at 500 when the domain itself is 64k

@alyosha-tas

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2018

What is the use case here?

I originally put that in as a stop gap so cheats would turn off properly once disposed of. I guess there is no reason not to raise the limit, but maybe there is a better way.

@NarryG

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2018

Practical use case: none.
Entertainment use case: memory corruption

I was hoping to be able to work entirely on the bus rather than with the separate domains so I could use pre-existing game genie codes to seed some addresses

@alyosha-tas

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2018

Ok I raised the cap to include the entire bus size (0x10000) since this doesn't affect performance as long as no cheats are active. Just be warned that as you add higher numbers of cheats things might slow down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.