Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mGBA Audio Keeps Playing Notes after Rewind #1195

Closed
NarryG opened this issue May 13, 2018 · 9 comments

Comments

Projects
None yet
4 participants
@NarryG
Copy link
Contributor

commented May 13, 2018

With the latest developer build, some GBA audio channels appear to not be properly cutting off when using rewind.

Example with Mario & Luigi Superstar Saga
https://streamable.com/lv1f1

This issue does not exist in the latest 0.6.X build of mGBA standalone.

@NarryG

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2018

Tagging @nattthebear as I know he deals with the mGBA core.

@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2018

Updated mgba. Still bugged?

@NarryG

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2018

This commit appears to have actually broken the core completely
image

@NarryG

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2018

The issue still persists @vadosnaprimer
I've compared against mGBA 0.6.3 stable and the issue appears to be upstream. I'll report it there. I must have made a mistake when I originally said it wasn't happening in standalone

@NarryG NarryG closed this Jun 23, 2018

@nattthebear

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2018

Why did we revert the palette changes? What's going on here?

@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2018

It was only reverted in my 1.x-only fork. tasvideos/mgba is fine, and it's what I used to build our current mgba.dll. I just accidentally used my 1.x build here initially.

@NarryG

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2018

The issue has been fixed upstream in the 0.7 branch. I requested endrift backport to 0.6.X
mgba-emu/mgba#1107

@NarryG NarryG reopened this Jun 24, 2018

@NarryG

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2018

It has been backported so it's now just a matter of updating the fork again.

@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.