Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect platform label in header file for Sonic Labyrinth Movies #1246

Closed
MemoryTAS opened this issue Jul 22, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@MemoryTAS
Copy link

commented Jul 22, 2018

In all current Bizhawk versions, if you record a movie file for Sonic Labyrinth, the header file will list the platform as SMS, when the game is in fact Game Gear. When you go to Play Movie and look at the header information, SMS will be marked in red because it is incorrect. I'm able to reproduce this in both 1.13.2 and 2.3. This may affect other Game Gear games as well but I am not certain.

@Asnivor

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2018

PR #1277

@MemoryTAS This actually affects all GG (and I think SG) games.

vadosnaprimer added a commit that referenced this issue Aug 22, 2018

Fix movie header SystemID (#1277)
From ticket #1246

Small change to MovieConversionExtensions.PopulateWithDefaultHeaderValues()

Just changes SystemID to "GG" or "SG" if Global.Emulator .IsGameGear or IsSG1000 is true.

Without this, the play movie dialog shows 'Platform' as SMS for game gear and SG1000 movies (and highlights this in RED as it is incorrect).

@vadosnaprimer vadosnaprimer reopened this Sep 21, 2018

@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2018

It doesn't affect anything. For whatever reason, when system info is dumped to the header, for GG it's written as SMS, with IsGameGear flag set. Similarly for SG1000 - SMS and IsSG1000 flag. But when these are looked up in the DB, their platform is GG and SG respectively, while the header has SMS. They are loaded just fine, and even the emuhawk caption tells the system correctly. Just this tiny check in PlayMovie is wrong.

@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2018

Here's the proper fix that I'm not applying, because there's no official decision to dump GG/SG to movie header.
proper-gg-sg-fix.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.