Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNES9x Code Converter is completely broken for GameShark #1293

Closed
Kippykip opened this issue Aug 22, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@Kippykip
Copy link

commented Aug 22, 2018

Using GameShark codes with the Code Converter throws a system.nullreferenceexception if SNES9X is the selected core.

Changing to bSNES solves the problem.
capture

@NarryG

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2018

Snes9X doesn't expose the System Bus. The code converter is supposed to not even open under Snes9X if I'm not mistaken.
Cheats are already pretty hit or miss in bizhawk due to various domains being write protected.

@Asnivor

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2018

The CodeConverter is either greyed out (on the tools menu) or hidden (in the cheats dialog) if GlobalWin.Tools.IsAvailable<GameShark>(); returns false.

This is based on the SupportedSystems ToolAttribute:

[Tool(released: true, supportedSystems: new[] { "GB", "GBA", "GEN", "N64", "NES", "PSX", "SAT", "SMS", "SNES" })]
	public partial class GameShark : Form, IToolForm, IToolFormAutoConfig

This check only looks at stuff based on the SystemID rather than the core itself.

I suspect that introducing an UnsupportedCores ToolAttribute would possibly be a way to solve this without too much adhoc messing around all over the place. I'll have a look and see if it looks doable.

@Asnivor

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2018

Fix merged to master a while ago.

@Asnivor Asnivor closed this Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.