Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GB in GBC becomes monocrome when loading a state #1337

Closed
ThunderAxe31 opened this issue Oct 6, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@ThunderAxe31
Copy link

commented Oct 6, 2018

Just as the title says. Also happens in DualGambatte.

How to trigger it:

  1. Open a GB game
  2. GB > Settings... > Console Mode > GBC
  3. Reboot core
  4. Play the game until the GBC BIOS screen has finished displaying
  5. Save a state
  6. Load that state.

This doesn't cause any emulation problem, it's a purely aesthetic bug, though I personally find it annoying while I work on a movie. I hope that it will be easy to fix.

@alyosha-tas

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2018

I am unable to reproduce this. I tested with the homebrew game retroid.gb
Does this only happen for specific games?

@alyosha-tas

This comment has been minimized.

Copy link
Contributor

commented Nov 11, 2018

I have found no conditions under which I can reproduce this bug, please reopen with more details if this still happens in the dev build

@ThunderAxe31

This comment has been minimized.

Copy link
Author

commented Nov 19, 2018

I can't reproduce the monocrome colours, however I was able to have it show a different palette than the supposed one. Here is what I did:

  1. Open a GB game
  2. GB > Settings... > Console Mode > GBC
  3. Reboot core
  4. During the GBC BIOS screen, press any joypad direction in order to set an alternate GBC palette
  5. Wait for the GBC BIOS to end
  6. Save a state
  7. Reboot core
  8. During the GBC BIOS screen, set a different palette than the one you choose before
  9. Wait for the GBC BIOS to end
  10. Load the state you previously created

The problem is that the emulator is keeping using the last palette you set, instead of the one you set before creating that savestate. This probably happens because the savestate it's not storing any information about the GBC palette used for the GB games (except for the savestate screenshot), however it should be included in the actual savestate data, because it's relevant to the gameplay.
As I said before, (as far as I know) this does not affect emulation, but it could cause confusion, because the palette used by GBC for GB games is determined by game inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.