Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAStudio branch screenshot is low resolution if window size changed #1513

Closed
Morilli opened this issue Mar 16, 2019 · 12 comments

Comments

Projects
None yet
3 participants
@Morilli
Copy link

commented Mar 16, 2019

I am using a lua script while making a TAS, and loading a branch makes the screenshot on branch load be shrunken down to the size of the in-game-screen. So basically the entire window area is captured and squeezed together to fit into the actual game window, making it look like this:
image
which renders the screenshot more or less useless.

@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2019

Is this on latest release?

@Morilli

This comment has been minimized.

Copy link
Author

commented Mar 16, 2019

Yes, version 2.3.1

@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2019

As pointed out by another person, it's lowres when you load the branch, I thought it was lowres on hover.

@Morilli

This comment has been minimized.

Copy link
Author

commented Jun 9, 2019

Yes sorry, I didn't even know a screenshot would show on branch hover when I made this issue.

@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

It works as 2 things at once, see if it's good now.

@Morilli

This comment has been minimized.

Copy link
Author

commented Jun 9, 2019

I would like to, but it seems that debugging / building the program either does not work or crashes immediately, so I'll just not do that I guess. Stating "run the .bat file" in the readme is really not helpful when there are apparently other dependencies that are not mentioned.

@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

@Morilli

This comment has been minimized.

Copy link
Author

commented Jun 9, 2019

I'm getting tons and tons of errors; I can absolutely not do anything productive with this build, sorry.

@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

That's what testing is for. What's the first error and how do you get it?

@Morilli

This comment has been minimized.

Copy link
Author

commented Jun 9, 2019

Just trying to open a previously created .tasproj file gives me this:
temp
Although this happens on the version 2.3.1 as well now; I'm assuming the dev build just destroyed my .tasproj file.
After switching between branches I also got this:
temp2

Other than that I could still reproduce the issue in that "interim" version I downloaded.

@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

It may be possible to fix the tasproject, see if it opens with 7zip. If it does, you can remove greenzone (if it's there) and upload it somewhere, I'll try fixing it.

To see if my commit was actually the cause of corruption, please to create a dummy tasproject with minimal data and a few dummy branches in 2.3.1, and try opening it in this build: https://ci.appveyor.com/api/buildjobs/umnso8p0ahhsy61l/artifacts/BizHawk_Developer-2019-06-02-233109-%230216359c1ffc9e3bc928ff10deb3c9a653c9db9b.zip

@Morilli

This comment has been minimized.

Copy link
Author

commented Jun 9, 2019

Can confirm that this earlier version you linked does NOT crash when loading a savestate / branch in a tasproj I made earlier. About the broken tasproj, it seems that all branch info is gone, whereas the input log is still there, but I already have a .bk2 of it, so I don't really need that. I might have a backup somewhere, so I'll what I can do. So far I haven't been able to see corruptions in files from loading them or even getting those errors, so that was probably from my attempts of running current master in VS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.