Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N64: Disabled Expansion Pak doesn't seem to be emulated accurately #1690

Open
flagrama opened this issue Oct 1, 2019 · 4 comments

Comments

@flagrama
Copy link

commented Oct 1, 2019

This seems to be a regression in mupen64plus-core.

Running a game that requires the Expansion Pak without one doesn't seem to "work" properly. Where working would mean either a black screen, or an error screen. This is confirmed to be an issue with Ocarina of Time Randomizer, and Majora's Mask.

image

We only realized this because Ocarina of Time Randomizer should not boot without the expansion slot, and yet only new code that stores music in the Expansion Pak RAM has started to cause issues. If you load a save state with these new code changes the game will crash when it tries to play the music.

Standalone mupen64plus-core (2.5.9) properly shows an error screen for Majora's Mask and a black screen for Ocarina of Time Randomizer when "DisableExtraMem" is enabled.

@YoshiRulz

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

Regression from which version? I'd like to bisect.

@Nicholas-Steel

This comment has been minimized.

Copy link

commented Oct 2, 2019

So loading the games works fine, no issues at all but loading a Save State causes issues. As far as my untrained eye can tell it seems like the Expansion Pak is enabled when it shouldn't be (option is not ticked) and the Load State is honouring the Expansion Pak option, causing the games to suddenly not have the right amount of RAM (and significant loss of data from the State that was loaded) resulting in the crashes.

@darkangel93x

This comment has been minimized.

Copy link

commented Oct 2, 2019

i assume you mean the BizHawk version usually 2.3.0 or higher.

@flagrama

This comment has been minimized.

Copy link
Author

commented Oct 4, 2019

I did some limited testing and from what I see BizHawk and mupen64plus-core 2.5 both behave the same. It's the new 2.5.9 pre-release I've been using that emulates the lack of expansion pak correctly. So not a regression, just more accurate emulation upstream that hasn't been added yet.

@YoshiRulz YoshiRulz added this to the Mupen64+ update milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.