Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TAStudio] The gap for platfroms with large savestate can be changed from 16 to 8 #915

Closed
TASeditor opened this issue Jul 11, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@TASeditor
Copy link
Contributor

commented Jul 11, 2017

Check how much memory the user provides for greenzone

@zeromus

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2017

So change it in the settings yourself

@zeromus zeromus closed this Jul 11, 2017

@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2017

Gap between states that are saved to ram as emulation runs can't be changed by the user.

@zeromus

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2017

then this bug should be "let user choose gap"
Before closing this bug I checked and confirmed the user can choose the gap. In powers of 2 for some strange reason.
It sounded like this bug was disagreeing with our choice of defaults

@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2017

No, the option that is there is the gap for saving a tasproject. This issue is about the gap between current ram savestates.

@zeromus

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2017

OK then this issue is still an opinion about the defaults for logic which is insanely complex in principle. And the bug should still be "let user adjust that logic"

What even motivated this bug? can be changed from 16 to 8? On what basis? @TASeditor upgraded his system ram? this bug is stupid.

@TASeditor

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2017

No, just using x64 builds. I don't really care wheter the defaults are changed or an option in savestate history settings is provided.

@adelikat adelikat self-assigned this Nov 2, 2017

@adelikat

This comment has been minimized.

Copy link
Contributor

commented Nov 2, 2017

I think making it configurable is a nice tastudio upgrade

@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Nov 3, 2017

Yeah I agree. It felt like a meaningful option for quite a while, even before this issue. I dunno if implementing it is gonna require new TSM, but I'm gonna reopen it now.

@vadosnaprimer vadosnaprimer reopened this Nov 3, 2017

@vadosnaprimer vadosnaprimer self-assigned this Nov 4, 2017

vadosnaprimer added a commit that referenced this issue Jan 2, 2018

smart state gap for greenzone. fix #915
disable disk capacity setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.