Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tastudio: drawing stuff, selection, patterns, add column lua function #1125

Merged
merged 22 commits into from Mar 8, 2018

Conversation

Projects
None yet
2 participants
@TASeditor
Copy link
Contributor

commented Mar 3, 2018

  • Selection drawing now only happens in FrameColumn or lua generated columns. Same with Shift and Control clicks.
  • Selection modification with Control. Ctrl+Left/Right: Add/Remove selection at last selected cell. Ctrl+Shift+Left/Right: Add/Remove selection at first selected cell.
  • Playback courser stuff happens with Shift. Shift+Up/Down: Rewind/Advance one frame. Shift + PageUp/PageDown: Go to previous/next marker with playback courser.
  • Draw input from first selected row to current cell if shift is held.
  • Draw pattern if Alt is held.
  • Apply pattern to selected rows when clicking on column header and Alt is held.
  • tastudio.addcolumn() lua function.

TODOs:

  • extraFloatRows can no longer be added by clicking on Float columns, users must use FrameColumn. Revert it.
  • Shift+Down holding repeatedly plays the current frame.
  • Don't add lua columns to tasproj file.
  • Display lua columns to ColumnsMenu.
  • Alt+Shift drawing pattern from first selected row to current cell.
  • Don't change focus to menu when clicking Alt.

TASeditor added some commits Jan 17, 2018

tastudio setinput(), setanaloginput()
autorestore not working proberly
tastudio.onbranchload()
I figured it out
tastudio onbranch... lua functions
and setinput/setanalog clean-up
tastudio lua input TAS Editor logic
deleted old functions
branch callbacks
help!
branch callbacks
should work now
shift/ctrl keys restructure to taseditor
shift + up/down: move frame courser up/down by one
shift + pageup/pagedown: move frame courser to next/prev marker
ctrl + left/right: add/remove selection at last selected row
ctrl + shift + left/right: add/remove selection at first selected row
Alt+drawing pattern
still not working with drawing upwards
pattern drawing
upwards drawing working except it doesn't update last row.
TODO: Disallow Alt click to focus on menu.
Lua columnms
TODO: Don't save them into tasproj
@vadosnaprimer

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2018

I think it's fine, but in future, create a separate PR for each feature.

@vadosnaprimer vadosnaprimer merged commit 6580c2a into TASVideos:master Mar 8, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.