Permalink
Browse files

Cocoa Port: Sigh... replace the pipe character '|' with a double-dash…

… '--' so that the generated .xcscheme file names won't screw up the file systems of lesser operating systems (cough... Windows... cough).
  • Loading branch information...
rogerman committed Sep 26, 2018
1 parent d9aa1ac commit e6b3dfd5bdf0dcbf06b0914e02d04e9d4619e8ca
@@ -2835,7 +2835,7 @@
ABDDF7C41898F024007583C1 /* Icon_DisplayToggle_420x420.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; name = Icon_DisplayToggle_420x420.png; path = images/Icon_DisplayToggle_420x420.png; sourceTree = "<group>"; };
ABDDF7C71898F032007583C1 /* Icon_FrameAdvance_420x420.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; name = Icon_FrameAdvance_420x420.png; path = images/Icon_FrameAdvance_420x420.png; sourceTree = "<group>"; };
ABDDF7C81898F032007583C1 /* Icon_FrameJump_420x420.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; name = Icon_FrameJump_420x420.png; path = images/Icon_FrameJump_420x420.png; sourceTree = "<group>"; };
ABE145B91FBBA71A0097A4A8 /* DeSmuME (Xcode 6).app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = "DeSmuME (Xcode 6).app"; sourceTree = BUILT_PRODUCTS_DIR; };
ABE145B91FBBA71A0097A4A8 /* DeSmuME (extract NIB).app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = "DeSmuME (extract NIB).app"; sourceTree = BUILT_PRODUCTS_DIR; };
ABE5DFE3143FB1DA00835AD8 /* cocoa_videofilter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = cocoa_videofilter.h; sourceTree = "<group>"; };
ABE5DFE4143FB1DA00835AD8 /* cocoa_videofilter.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = cocoa_videofilter.mm; sourceTree = "<group>"; };
ABE670251415DE6C00E8E4C9 /* tinystr.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = tinystr.cpp; sourceTree = "<group>"; };
@@ -3234,7 +3234,7 @@
ABB3C6471501BC6D00E0C22E /* DeSmuME.oecoreplugin */,
AB796D7015CDCBA200C59155 /* DeSmuME (Debug).app */,
AB8F3D2E1A53AC2600A80BF6 /* DeSmuME (Debug, dev+).app */,
ABE145B91FBBA71A0097A4A8 /* DeSmuME (Xcode 6).app */,
ABE145B91FBBA71A0097A4A8 /* DeSmuME (extract NIB).app */,
AB79013D215B84E50082AE82 /* DeSmuME (Debug).app */,
AB79029A215B84F20082AE82 /* DeSmuME (Debug, dev+).app */,
);
@@ -4383,9 +4383,9 @@
/* End PBXGroup section */
/* Begin PBXNativeTarget section */
8D1107260486CEB800E47090 /* DeSmuME (OS X App; v10.5 Leopard Release Build | Xcode 9) */ = {
8D1107260486CEB800E47090 /* DeSmuME (OS X App; v10.5 Leopard Release Build -- Xcode 9) */ = {
isa = PBXNativeTarget;
buildConfigurationList = C01FCF4A08A954540054247B /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App; v10.5 Leopard Release Build | Xcode 9)" */;
buildConfigurationList = C01FCF4A08A954540054247B /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App; v10.5 Leopard Release Build -- Xcode 9)" */;
buildPhases = (
8D1107290486CEB800E47090 /* Resources */,
8D11072C0486CEB800E47090 /* Sources */,
@@ -4396,15 +4396,15 @@
);
dependencies = (
);
name = "DeSmuME (OS X App; v10.5 Leopard Release Build | Xcode 9)";
name = "DeSmuME (OS X App; v10.5 Leopard Release Build -- Xcode 9)";
productInstallPath = "$(HOME)/Applications";
productName = DeSmuME;
productReference = 8D1107320486CEB800E47090 /* DeSmuME.app */;
productType = "com.apple.product-type.application";
};
AB79013F215B84F20082AE82 /* DeSmuME (OS X App with 32-bit; dev+ | Xcode 9) */ = {
AB79013F215B84F20082AE82 /* DeSmuME (OS X App with 32-bit; dev+ -- Xcode 9) */ = {
isa = PBXNativeTarget;
buildConfigurationList = AB790297215B84F20082AE82 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App with 32-bit; dev+ | Xcode 9)" */;
buildConfigurationList = AB790297215B84F20082AE82 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App with 32-bit; dev+ -- Xcode 9)" */;
buildPhases = (
AB790140215B84F20082AE82 /* ShellScript */,
AB790141215B84F20082AE82 /* Resources */,
@@ -4416,15 +4416,15 @@
);
dependencies = (
);
name = "DeSmuME (OS X App with 32-bit; dev+ | Xcode 9)";
name = "DeSmuME (OS X App with 32-bit; dev+ -- Xcode 9)";
productInstallPath = "$(HOME)/Applications";
productName = DeSmuME;
productReference = AB79029A215B84F20082AE82 /* DeSmuME (Debug, dev+).app */;
productType = "com.apple.product-type.application";
};
AB796CA415CDCBA200C59155 /* DeSmuME (OS X App | Latest Xcode) */ = {
AB796CA415CDCBA200C59155 /* DeSmuME (OS X App -- Latest Xcode) */ = {
isa = PBXNativeTarget;
buildConfigurationList = AB796D6D15CDCBA200C59155 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App | Latest Xcode)" */;
buildConfigurationList = AB796D6D15CDCBA200C59155 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App -- Latest Xcode)" */;
buildPhases = (
AB796CA515CDCBA200C59155 /* ShellScript */,
AB796CA615CDCBA200C59155 /* Resources */,
@@ -4437,15 +4437,15 @@
);
dependencies = (
);
name = "DeSmuME (OS X App | Latest Xcode)";
name = "DeSmuME (OS X App -- Latest Xcode)";
productInstallPath = "$(HOME)/Applications";
productName = DeSmuME;
productReference = AB796D7015CDCBA200C59155 /* DeSmuME (Debug).app */;
productType = "com.apple.product-type.application";
};
AB79FFE2215B84E50082AE82 /* DeSmuME (OS X App with 32-bit | Xcode 9) */ = {
AB79FFE2215B84E50082AE82 /* DeSmuME (OS X App with 32-bit -- Xcode 9) */ = {
isa = PBXNativeTarget;
buildConfigurationList = AB79013A215B84E50082AE82 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App with 32-bit | Xcode 9)" */;
buildConfigurationList = AB79013A215B84E50082AE82 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App with 32-bit -- Xcode 9)" */;
buildPhases = (
AB79FFE3215B84E50082AE82 /* ShellScript */,
AB79FFE4215B84E50082AE82 /* Resources */,
@@ -4458,15 +4458,15 @@
);
dependencies = (
);
name = "DeSmuME (OS X App with 32-bit | Xcode 9)";
name = "DeSmuME (OS X App with 32-bit -- Xcode 9)";
productInstallPath = "$(HOME)/Applications";
productName = DeSmuME;
productReference = AB79013D215B84E50082AE82 /* DeSmuME (Debug).app */;
productType = "com.apple.product-type.application";
};
AB8F3C171A53AC2600A80BF6 /* DeSmuME (OS X App; dev+ | Latest Xcode) */ = {
AB8F3C171A53AC2600A80BF6 /* DeSmuME (OS X App; dev+ -- Latest Xcode) */ = {
isa = PBXNativeTarget;
buildConfigurationList = AB8F3D2B1A53AC2600A80BF6 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App; dev+ | Latest Xcode)" */;
buildConfigurationList = AB8F3D2B1A53AC2600A80BF6 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App; dev+ -- Latest Xcode)" */;
buildPhases = (
AB8F3C181A53AC2600A80BF6 /* ShellScript */,
AB8F3C191A53AC2600A80BF6 /* Resources */,
@@ -4478,15 +4478,15 @@
);
dependencies = (
);
name = "DeSmuME (OS X App; dev+ | Latest Xcode)";
name = "DeSmuME (OS X App; dev+ -- Latest Xcode)";
productInstallPath = "$(HOME)/Applications";
productName = DeSmuME;
productReference = AB8F3D2E1A53AC2600A80BF6 /* DeSmuME (Debug, dev+).app */;
productType = "com.apple.product-type.application";
};
ABB3C6461501BC6D00E0C22E /* DeSmuME (OpenEmu Plug-in | Latest Xcode) */ = {
ABB3C6461501BC6D00E0C22E /* DeSmuME (OpenEmu Plug-in -- Latest Xcode) */ = {
isa = PBXNativeTarget;
buildConfigurationList = ABB3C6571501BC6D00E0C22E /* Build configuration list for PBXNativeTarget "DeSmuME (OpenEmu Plug-in | Latest Xcode)" */;
buildConfigurationList = ABB3C6571501BC6D00E0C22E /* Build configuration list for PBXNativeTarget "DeSmuME (OpenEmu Plug-in -- Latest Xcode)" */;
buildPhases = (
ABB3C6611501BF3700E0C22E /* Resources */,
AB2DF23515E0839D00B4D0BC /* ShellScript */,
@@ -4497,14 +4497,14 @@
);
dependencies = (
);
name = "DeSmuME (OpenEmu Plug-in | Latest Xcode)";
name = "DeSmuME (OpenEmu Plug-in -- Latest Xcode)";
productName = DeSmuME;
productReference = ABB3C6471501BC6D00E0C22E /* DeSmuME.oecoreplugin */;
productType = "com.apple.product-type.bundle";
};
ABE144581FBBA71A0097A4A8 /* DeSmuME (OS X App; .NIB for v10.5 Leopard Release Build | Xcode 6) */ = {
ABE144581FBBA71A0097A4A8 /* DeSmuME (OS X App; .NIB for v10.5 Leopard Release Build -- Xcode 6) */ = {
isa = PBXNativeTarget;
buildConfigurationList = ABE145B61FBBA71A0097A4A8 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App; .NIB for v10.5 Leopard Release Build | Xcode 6)" */;
buildConfigurationList = ABE145B61FBBA71A0097A4A8 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App; .NIB for v10.5 Leopard Release Build -- Xcode 6)" */;
buildPhases = (
ABE1445A1FBBA71A0097A4A8 /* Resources */,
ABE144CD1FBBA71A0097A4A8 /* Sources */,
@@ -4514,10 +4514,10 @@
);
dependencies = (
);
name = "DeSmuME (OS X App; .NIB for v10.5 Leopard Release Build | Xcode 6)";
name = "DeSmuME (OS X App; .NIB for v10.5 Leopard Release Build -- Xcode 6)";
productInstallPath = "$(HOME)/Applications";
productName = DeSmuME;
productReference = ABE145B91FBBA71A0097A4A8 /* DeSmuME (Xcode 6).app */;
productReference = ABE145B91FBBA71A0097A4A8 /* DeSmuME (extract NIB).app */;
productType = "com.apple.product-type.application";
};
/* End PBXNativeTarget section */
@@ -4548,13 +4548,13 @@
projectDirPath = "";
projectRoot = "";
targets = (
AB796CA415CDCBA200C59155 /* DeSmuME (OS X App | Latest Xcode) */,
AB8F3C171A53AC2600A80BF6 /* DeSmuME (OS X App; dev+ | Latest Xcode) */,
AB79FFE2215B84E50082AE82 /* DeSmuME (OS X App with 32-bit | Xcode 9) */,
AB79013F215B84F20082AE82 /* DeSmuME (OS X App with 32-bit; dev+ | Xcode 9) */,
ABE144581FBBA71A0097A4A8 /* DeSmuME (OS X App; .NIB for v10.5 Leopard Release Build | Xcode 6) */,
8D1107260486CEB800E47090 /* DeSmuME (OS X App; v10.5 Leopard Release Build | Xcode 9) */,
ABB3C6461501BC6D00E0C22E /* DeSmuME (OpenEmu Plug-in | Latest Xcode) */,
AB796CA415CDCBA200C59155 /* DeSmuME (OS X App -- Latest Xcode) */,
AB8F3C171A53AC2600A80BF6 /* DeSmuME (OS X App; dev+ -- Latest Xcode) */,
AB79FFE2215B84E50082AE82 /* DeSmuME (OS X App with 32-bit -- Xcode 9) */,
AB79013F215B84F20082AE82 /* DeSmuME (OS X App with 32-bit; dev+ -- Xcode 9) */,
ABE144581FBBA71A0097A4A8 /* DeSmuME (OS X App; .NIB for v10.5 Leopard Release Build -- Xcode 6) */,
8D1107260486CEB800E47090 /* DeSmuME (OS X App; v10.5 Leopard Release Build -- Xcode 9) */,
ABB3C6461501BC6D00E0C22E /* DeSmuME (OpenEmu Plug-in -- Latest Xcode) */,
);
};
/* End PBXProject section */
@@ -7290,7 +7290,7 @@
/* End XCBuildConfiguration section */
/* Begin XCConfigurationList section */
AB79013A215B84E50082AE82 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App with 32-bit | Xcode 9)" */ = {
AB79013A215B84E50082AE82 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App with 32-bit -- Xcode 9)" */ = {
isa = XCConfigurationList;
buildConfigurations = (
AB79013B215B84E50082AE82 /* Debug */,
@@ -7299,7 +7299,7 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
AB790297215B84F20082AE82 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App with 32-bit; dev+ | Xcode 9)" */ = {
AB790297215B84F20082AE82 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App with 32-bit; dev+ -- Xcode 9)" */ = {
isa = XCConfigurationList;
buildConfigurations = (
AB790298215B84F20082AE82 /* Debug */,
@@ -7308,7 +7308,7 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
AB796D6D15CDCBA200C59155 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App | Latest Xcode)" */ = {
AB796D6D15CDCBA200C59155 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App -- Latest Xcode)" */ = {
isa = XCConfigurationList;
buildConfigurations = (
AB796D6E15CDCBA200C59155 /* Debug */,
@@ -7317,7 +7317,7 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
AB8F3D2B1A53AC2600A80BF6 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App; dev+ | Latest Xcode)" */ = {
AB8F3D2B1A53AC2600A80BF6 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App; dev+ -- Latest Xcode)" */ = {
isa = XCConfigurationList;
buildConfigurations = (
AB8F3D2C1A53AC2600A80BF6 /* Debug */,
@@ -7326,7 +7326,7 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
ABB3C6571501BC6D00E0C22E /* Build configuration list for PBXNativeTarget "DeSmuME (OpenEmu Plug-in | Latest Xcode)" */ = {
ABB3C6571501BC6D00E0C22E /* Build configuration list for PBXNativeTarget "DeSmuME (OpenEmu Plug-in -- Latest Xcode)" */ = {
isa = XCConfigurationList;
buildConfigurations = (
ABB3C6581501BC6D00E0C22E /* Debug */,
@@ -7335,7 +7335,7 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
ABE145B61FBBA71A0097A4A8 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App; .NIB for v10.5 Leopard Release Build | Xcode 6)" */ = {
ABE145B61FBBA71A0097A4A8 /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App; .NIB for v10.5 Leopard Release Build -- Xcode 6)" */ = {
isa = XCConfigurationList;
buildConfigurations = (
ABE145B71FBBA71A0097A4A8 /* Debug */,
@@ -7344,7 +7344,7 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
C01FCF4A08A954540054247B /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App; v10.5 Leopard Release Build | Xcode 9)" */ = {
C01FCF4A08A954540054247B /* Build configuration list for PBXNativeTarget "DeSmuME (OS X App; v10.5 Leopard Release Build -- Xcode 9)" */ = {
isa = XCConfigurationList;
buildConfigurations = (
C01FCF4B08A954540054247B /* Debug */,
@@ -16,7 +16,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "AB796CA415CDCBA200C59155"
BuildableName = "DeSmuME.app"
BlueprintName = "DeSmuME (OS X App | Latest Xcode)"
BlueprintName = "DeSmuME (OS X App -- Latest Xcode)"
ReferencedContainer = "container:DeSmuME (Latest).xcodeproj">
</BuildableReference>
</BuildActionEntry>
@@ -34,7 +34,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "AB796CA415CDCBA200C59155"
BuildableName = "DeSmuME.app"
BlueprintName = "DeSmuME (OS X App | Latest Xcode)"
BlueprintName = "DeSmuME (OS X App -- Latest Xcode)"
ReferencedContainer = "container:DeSmuME (Latest).xcodeproj">
</BuildableReference>
</MacroExpansion>
@@ -59,7 +59,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "AB796CA415CDCBA200C59155"
BuildableName = "DeSmuME.app"
BlueprintName = "DeSmuME (OS X App | Latest Xcode)"
BlueprintName = "DeSmuME (OS X App -- Latest Xcode)"
ReferencedContainer = "container:DeSmuME (Latest).xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
@@ -78,7 +78,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "AB796CA415CDCBA200C59155"
BuildableName = "DeSmuME.app"
BlueprintName = "DeSmuME (OS X App | Latest Xcode)"
BlueprintName = "DeSmuME (OS X App -- Latest Xcode)"
ReferencedContainer = "container:DeSmuME (Latest).xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
@@ -16,7 +16,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "AB79FFE2215B84E50082AE82"
BuildableName = "DeSmuME.app"
BlueprintName = "DeSmuME (OS X App with 32-bit | Xcode 9)"
BlueprintName = "DeSmuME (OS X App with 32-bit -- Xcode 9)"
ReferencedContainer = "container:DeSmuME (Latest).xcodeproj">
</BuildableReference>
</BuildActionEntry>
@@ -34,7 +34,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "AB79FFE2215B84E50082AE82"
BuildableName = "DeSmuME.app"
BlueprintName = "DeSmuME (OS X App with 32-bit | Xcode 9)"
BlueprintName = "DeSmuME (OS X App with 32-bit -- Xcode 9)"
ReferencedContainer = "container:DeSmuME (Latest).xcodeproj">
</BuildableReference>
</MacroExpansion>
@@ -57,7 +57,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "AB79FFE2215B84E50082AE82"
BuildableName = "DeSmuME.app"
BlueprintName = "DeSmuME (OS X App with 32-bit | Xcode 9)"
BlueprintName = "DeSmuME (OS X App with 32-bit -- Xcode 9)"
ReferencedContainer = "container:DeSmuME (Latest).xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
@@ -76,7 +76,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "AB79FFE2215B84E50082AE82"
BuildableName = "DeSmuME.app"
BlueprintName = "DeSmuME (OS X App with 32-bit | Xcode 9)"
BlueprintName = "DeSmuME (OS X App with 32-bit -- Xcode 9)"
ReferencedContainer = "container:DeSmuME (Latest).xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
@@ -16,7 +16,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "AB79013F215B84F20082AE82"
BuildableName = "DeSmuME (dev+).app"
BlueprintName = "DeSmuME (OS X App with 32-bit; dev+ | Xcode 9)"
BlueprintName = "DeSmuME (OS X App with 32-bit; dev+ -- Xcode 9)"
ReferencedContainer = "container:DeSmuME (Latest).xcodeproj">
</BuildableReference>
</BuildActionEntry>
@@ -34,7 +34,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "AB79013F215B84F20082AE82"
BuildableName = "DeSmuME (dev+).app"
BlueprintName = "DeSmuME (OS X App with 32-bit; dev+ | Xcode 9)"
BlueprintName = "DeSmuME (OS X App with 32-bit; dev+ -- Xcode 9)"
ReferencedContainer = "container:DeSmuME (Latest).xcodeproj">
</BuildableReference>
</MacroExpansion>
@@ -57,7 +57,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "AB79013F215B84F20082AE82"
BuildableName = "DeSmuME (dev+).app"
BlueprintName = "DeSmuME (OS X App with 32-bit; dev+ | Xcode 9)"
BlueprintName = "DeSmuME (OS X App with 32-bit; dev+ -- Xcode 9)"
ReferencedContainer = "container:DeSmuME (Latest).xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
@@ -76,7 +76,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "AB79013F215B84F20082AE82"
BuildableName = "DeSmuME (dev+).app"
BlueprintName = "DeSmuME (OS X App with 32-bit; dev+ | Xcode 9)"
BlueprintName = "DeSmuME (OS X App with 32-bit; dev+ -- Xcode 9)"
ReferencedContainer = "container:DeSmuME (Latest).xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
Oops, something went wrong.

4 comments on commit e6b3dfd

@Jules-A

This comment has been minimized.

Show comment
Hide comment
@Jules-A

Jules-A Sep 26, 2018

Hey, a bit off-topic (didn't want to create an issue) but will you be updating Nightly builds? Windows 15th build crashes on Rom load and the AppVeyor x64 builds grew from 9MB to 27MB from build 407 (not an issue just don't understand why).

Jules-A replied Sep 26, 2018

Hey, a bit off-topic (didn't want to create an issue) but will you be updating Nightly builds? Windows 15th build crashes on Rom load and the AppVeyor x64 builds grew from 9MB to 27MB from build 407 (not an issue just don't understand why).

@rogerman

This comment has been minimized.

Show comment
Hide comment
@rogerman

rogerman Sep 26, 2018

Collaborator

I can confirm that the 2018/09/15 Windows build does crash upon ROM loading. This is certainly due to one of the PR commits that broke it. More research will need to be made here, and once the problem is fixed, a new nightly build will be made.

The reason why the app size grew so much is because new GPU code in commit acb1402 allowed for the compiler to do some more inlining, for which MSVC was more than happy to do, and then some. Once the Windows build is fixed, I'll need to do a performance check on the new code to see if any performance regressions exist, but I'm guessing that there won't be. I'm suspecting that the new code should make this a little bit faster.

Collaborator

rogerman replied Sep 26, 2018

I can confirm that the 2018/09/15 Windows build does crash upon ROM loading. This is certainly due to one of the PR commits that broke it. More research will need to be made here, and once the problem is fixed, a new nightly build will be made.

The reason why the app size grew so much is because new GPU code in commit acb1402 allowed for the compiler to do some more inlining, for which MSVC was more than happy to do, and then some. Once the Windows build is fixed, I'll need to do a performance check on the new code to see if any performance regressions exist, but I'm guessing that there won't be. I'm suspecting that the new code should make this a little bit faster.

@rogerman

This comment has been minimized.

Show comment
Hide comment
@rogerman

rogerman Sep 27, 2018

Collaborator

So there was no actual coding problem after all -- it was actually a problem with the 2018/09/15 build itself. I just did a complete solution clean on everything and did a rebuild, and now all is well. The 2018/09/15 nightly build based on commit 1767651 was re-uploaded and should work fine now. I've also made a 2018/09/26 nightly build based on this commit, which should be uploaded by the time you read this.

Collaborator

rogerman replied Sep 27, 2018

So there was no actual coding problem after all -- it was actually a problem with the 2018/09/15 build itself. I just did a complete solution clean on everything and did a rebuild, and now all is well. The 2018/09/15 nightly build based on commit 1767651 was re-uploaded and should work fine now. I've also made a 2018/09/26 nightly build based on this commit, which should be uploaded by the time you read this.

@Jules-A

This comment has been minimized.

Show comment
Hide comment
@Jules-A

Jules-A Sep 28, 2018

That's what I assumed, thanks. I just did a 1min benchmark run in Pokemon HG and the 15th build seemed to perform slightly better than the 26th, average FPS was only slightly lower but I saw it dropping below 60 a few times.

2018-09-28 11:53:51 - DeSmuME_git#1767651_x6415
Frames: 4155 - Time: 60000ms - Avg: 69.250 - Min: 62 - Max: 90
2018-09-28 11:55:28 - DeSmuME_git#e6b3dfd_x6426
Frames: 4124 - Time: 60000ms - Avg: 68.733 - Min: 59 - Max: 88

Jules-A replied Sep 28, 2018

That's what I assumed, thanks. I just did a 1min benchmark run in Pokemon HG and the 15th build seemed to perform slightly better than the 26th, average FPS was only slightly lower but I saw it dropping below 60 a few times.

2018-09-28 11:53:51 - DeSmuME_git#1767651_x6415
Frames: 4155 - Time: 60000ms - Avg: 69.250 - Min: 62 - Max: 90
2018-09-28 11:55:28 - DeSmuME_git#e6b3dfd_x6426
Frames: 4124 - Time: 60000ms - Avg: 68.733 - Min: 59 - Max: 88

Please sign in to comment.