Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive project if no New Maintainers found #65

Closed
dugite-code opened this issue Jun 30, 2020 · 9 comments
Closed

Archive project if no New Maintainers found #65

dugite-code opened this issue Jun 30, 2020 · 9 comments
Labels
help wanted Extra attention is needed

Comments

@dugite-code
Copy link
Collaborator

Due to changes coming in Thunderbird 78 and lack of time I am currently unable to actively maintain the project.

I still will be able to actively review pull requests when submitted so if you are interested in contributing please submit changes. Once I have someone actively contributing I will add them to the organization to allow them to perform administrative tasks.

@dugite-code dugite-code added the help wanted Extra attention is needed label Jun 30, 2020
@dugite-code dugite-code pinned this issue Jun 30, 2020
@mhillct
Copy link

mhillct commented Nov 4, 2020

I've been meaning to learn to do this for a while now due to a number of add-ons in the same state and in order to implement something of my own for which I can find no add-on. If you could post any advice on getting up to speed, links to resources, etc. it would help me and other potential contributors.

@dugite-code
Copy link
Collaborator Author

dugite-code commented Nov 5, 2020

It's great that you're willing to even look into helping any development. Currently this add-on and many others are stuck between being a Traditional XUL add-on and the modern MailExtension add-ons. Lookout for example is using the Wrapper API to make some of the old XUL code work in TB 78, it should be noted quite a bit of that code has already been phased out of TB78

MailExtensions share the majority of the design choices with WebExtensions in Firefox so starting with these docs is recommended. There is also legacy docs available for XUL extensions if you need to figure out what is going on there.


Main developer Hub page: https://developer.thunderbird.net/

@dugite-code
Copy link
Collaborator Author

Unfortunately my company has switched back to Outlook from Thunderbird and so I now really only have my free time to do support.

What needs doing:

Continue porting to MailExtension. Thanks to John Bieling the plugin uses the Experiment wrapper API to add basic support for Thunderbird 78 however the plugin is broadly unchanged internally and needs to be converted to use the MailExtension API's.

  • True lightning integration (this was a very hacky solution).

  • Files cannot be drag and dropped from Thunderbird to the desktop.

  • Decoded files are not used when forwarding an email message.

  • The html body in modern TNEF emails isn't displayed and only shown as an attachment.

I know that proper integration for decoding TNEF emails was added to the roadmap for this year however it looks like this is being pushed back to TB 91+ https://developer.thunderbird.net/planning/roadmap-1#investigate-microsoft-tnef-support-tb-2022

Also see the Tracked bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=77811

I wish I was still able to use Thunderbird for my day to day work. Thank you to anyone who has provided help with this plugin and I look forward to someone taking this up in the future.

@dugite-code dugite-code changed the title New Maintainers wanted Archive project if no New Maintainers found Aug 17, 2021
@dugite-code
Copy link
Collaborator Author

This Project will become archived in 3 months from today if no new maintainers are found

@jobisoft
Copy link
Collaborator

I could take it (I am Thunderbird's add-on support engineer). What are the next steps?

@dugite-code
Copy link
Collaborator Author

@jobisoft I've added you as a maintainer to the project. I'll look into the ATN page permissions shortly, I think Oleksandr gave me permissions to add people there. If not I'm happy to continue doing the releases I just don't have the personal time for much coding these days.

As far as work needed to be done unfortunately I've only done some minor tweeks since implementing the Experiment wrapper API and as far as I understand it needs a complete port over to the mailextension. Last time I looked the messageId returned by messageDisplay wasn't the same as the ID used in MessagePart However I don't see the note for that in the current docs.

Theoretically the tnef.js should require no re-working to be used.


F.Y.I. for anyone who is unfamiliar with the project, I am familiar with jobisoft and he contributed heavily to the work implementing the TB 78 Experiment wrapper API for lookout.

@jobisoft
Copy link
Collaborator

... and as far as I understand it needs a complete port over to the mailextension.

Experiments are still allowed, so we need to update the WindowListener API (which I fixed for TB91) and check a few internal changes. Once a working release is out, I will either focus on merging this into core (if it is accepted) or work on the WebExtension conversion.

Last time I looked the messageId returned by messageDisplay wasn't the same as the ID used in MessagePart However I don't see the note for that in the current docs.

The WebExtension API is using unique IDs (not persistent across sessions), while two messages could have the same messageHeaderId. The messageHeaderId however is exposed since TB85 in the MessageHeader:
https://webextension-api.thunderbird.net/en/91/messages.html#messageheader

@jobisoft
Copy link
Collaborator

If someone wants to try the updated version:
#74

@dugite-code dugite-code unpinned this issue Aug 23, 2021
@jobisoft
Copy link
Collaborator

I will do my best to keep this going, or to get it into core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants