Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Duplicate Methods used in sync #738

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

LiranCohen
Copy link
Member

  • remove duplicate methods used in sync.
  • fix bug where only RecordsWrite messages were being synced & add coverage

Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: 95b65f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@web5/agent Patch
@web5/identity-agent Patch
@web5/proxy-agent Patch
@web5/user-agent Patch
@web5/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LiranCohen LiranCohen force-pushed the lirancohen/simplify-sync-specific-methods branch from c4a5b4f to ca8fed4 Compare July 3, 2024 19:39
@@ -132,27 +134,18 @@ export class SyncEngineLevel implements SyncEngine {
}

const replyEntry = reply.entry;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only syncing RecordsWrite messages, added test path for ProtocolsConfigure message and simplified the logic here.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-07-03T19:49:00Z 95b65f7

@LiranCohen LiranCohen marked this pull request as ready for review July 3, 2024 19:45
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (89f239d) to head (95b65f7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   91.27%   91.25%   -0.03%     
==========================================
  Files         119      119              
  Lines       30058    30020      -38     
  Branches     2256     2254       -2     
==========================================
- Hits        27435    27394      -41     
- Misses       2589     2592       +3     
  Partials       34       34              
Components Coverage Δ
agent 81.74% <100.00%> (-0.07%) ⬇️
api 94.01% <ø> (-0.15%) ⬇️
common 98.68% <ø> (ø)
credentials 94.88% <ø> (ø)
crypto 93.81% <ø> (ø)
dids 97.77% <ø> (ø)
identity-agent 96.70% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.70% <ø> (ø)
user-agent 96.70% <ø> (ø)

@LiranCohen LiranCohen merged commit bc54d0c into main Jul 3, 2024
35 checks passed
@LiranCohen LiranCohen deleted the lirancohen/simplify-sync-specific-methods branch July 3, 2024 20:22
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants