-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Duplicate Methods used in sync #738
Conversation
LiranCohen
commented
Jul 3, 2024
- remove duplicate methods used in sync.
- fix bug where only RecordsWrite messages were being synced & add coverage
🦋 Changeset detectedLatest commit: 95b65f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… protocol configure to e2e sync test
c4a5b4f
to
ca8fed4
Compare
@@ -132,27 +134,18 @@ export class SyncEngineLevel implements SyncEngine { | |||
} | |||
|
|||
const replyEntry = reply.entry; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was only syncing RecordsWrite
messages, added test path for ProtocolsConfigure
message and simplified the logic here.
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-07-03T19:49:00Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
==========================================
- Coverage 91.27% 91.25% -0.03%
==========================================
Files 119 119
Lines 30058 30020 -38
Branches 2256 2254 -2
==========================================
- Hits 27435 27394 -41
- Misses 2589 2592 +3
Partials 34 34
|