Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking Save Edited Photo does not close the modal in Student Profile page #9574

Closed
monmanuela opened this issue Mar 14, 2019 · 2 comments · Fixed by #9575
Closed

Clicking Save Edited Photo does not close the modal in Student Profile page #9574

monmanuela opened this issue Mar 14, 2019 · 2 comments · Fixed by #9575
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors

Comments

@monmanuela
Copy link
Contributor

  • Environment: Environment: master branch, commit ba5b2ef

Steps to reproduce

  • Go to Students Profile page
  • Click Upload/Edit Photo, choose a new photo
  • Click Save Edited Photo

Expected behaviour
The photo should be changed and the modal should be closed

Actual behaviour
The modal remains open although the photo is changed
image
@monmanuela monmanuela added a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors v7-only labels Mar 14, 2019
@Davileal Davileal mentioned this issue Mar 19, 2019
Closed
@sil3nthill
Copy link

hello i would like to fix this if its ok !

@monmanuela
Copy link
Contributor Author

Hi @sil3nthill, thank you for your interest in contributing to TEAMMATES! However, there's already an open PR for this (#9588) so please look into other issues to prevent duplicate work 😄

@rrtheonlyone rrtheonlyone mentioned this issue Mar 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors
Projects
None yet
Milestone
No milestone
2 participants
@sil3nthill @monmanuela