-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inconsistent wording of descriptions of attr classes with only 1 attr #2142
Comments
I've been thinking about this and on a theoretical level I think that class descriptions should always be plural. This holds for model classes as well where appropriate. The reasons something is in a class is basically because it makes sense to semantically group it with related things or it will be used in lots of places alongside those things and specifying it by class is easier than specifying all the individual members. But also it is a class so that customisers may add something to the class and get the benefit of appearing wherever that class is referenced. If it is singular and I add a new element or attribute then I've got to go and change the class description or have my documentation look wrong. Whereas having it plural means that we're indicating it is for attributes or elements of that semantic concept or useful grouping that may or may not be included yet. It is a statement of intention that you can add pLike elements here or facsimile-related attributes there. It is a statement of potential, it is a statement of hope. |
I’m convinced, @jamescummings. (That said, someone else could convince me otherwise, I suppose. But my hobgoblin mind probably cannot be convinced that the inconsistency is a good idea.) |
I agree with both of you. I also prefer consistency and I think the class descriptions should be plural. |
I re-thought this earlier today, without reading my previous comments, and was pleased to find that I pretty much agree with my former self: I mildly prefer plural, but don’t really care much, so long as they are consistent. |
I prefer this wording over the two options on which we are currently voting: "The class provides one or more attributes..." That wording is consistent and true in every case. |
At first blush, that is an awfully good idea, @JanelleJenstad. Two (perhaps minor) concerns jump to mind:
I think I can handle concern (2) pretty easily. If the customizer has removed the last attribute, she is responsible for either just deleting the class or changing the description. We can’t be responsible for extreme actions like that. But (1) does give me a bit of reason for pause. I think the answer is “well, maybe a little, but no more silly than using the plural when we know there is only 1, and you’re perfectly OK with that, Syd”, but it would make me feel better if others think (1) is not a problem. |
Hi all! Having just written up |
I like @ebeshero's optimism. The potentiality of the plural is indeed full of hope. (I don't object to plurals, even though I like my suggestion, so perhaps the strong consensus on plurals means we should go with them.) |
I agree. Customizers may add new attributes to a class containing only one, or remove attributes so that a class ends up containing only one, so "one or more' is the most robust formulation. |
Really good idea @JanelleJenstad, I didn't think of it when setting up the poll. I've now looked at the model classes and we use plurals there, even for classes with only one element (see https://tei-c.org/release/doc/tei-p5-doc/en/html/ref-model.applicationLike.html). One option would be to also change the description of the model classes to "one or more". Nevertheless, I lean towards plurals. |
Just as I believe in a singular 'they', I also believe in a non-specific plural of potentiality. I've nothing against 'one or more' but saying a class 'provides attributes' in my mind doesn't actually specify whether there are zero, one, or more attributes. It is non-specific in that it just says the class 'provides attributes' which I take also to mean 'potentially provides attributes' without the word potentially there because any class could have zero, one, or more attributes because the TEI framework allows customisation. Having a plural 'provides attributes' says that the job of the class is to provide attributes regardless of whatever the reality may be. (Same with model classes) But if you went with 'zero or more' I wouldn't complain. |
In this context, the restrictive pronouns in the descriptions have been changed from "which" to "that", see #2176 |
When describing (in
classSpec/desc
) a class that has only 1 attribute we are inconsistent as to whether we say the class “provides an attribute” or “provides attributes”.The text was updated successfully, but these errors were encountered: