Fix #2187, I hope

[sydb]

Just adding <constraintSpec> to elements that get copied to subset.

[martindholmes]

Looks good to me.

[HelenaSabel]

Test fails with error: /tei/P5/Test/detest.odd:457:86: error: element "constraintSpec" incomplete; missing required element "constraint"

European VF2F thinks that the PR should also include the fix of the test.

[sydb]

Ummm… the error is catching a real problem, isn’t it? That the content model of <constraintSpec> requires a child <constraint> even if @mode is "delete". So it seems to me the right solution is to add an empty <constraint> to the detest.odd file, and open another ticket that the Guidelines should properly explain how to delete or change a <constraintSpec>. (Which might include changing content models and adding constraints.)

[sydb]

Council meeting of today votes to change Stylesheets so that

<constraintSpec mode="delete" scheme="schematron"/>

is what is used to delete a constraint specification, not requiring a child <constraint>.

[sydb]

OK. Schema, not test, fixed. I think this is quite ready to be merged, now.

[peterstadler]

I'm unable to find the change that caused the error reported at #2188 (comment) to vanish, but hey, seems ok to me :)