Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constrain attributes of elementRef #2552

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Conversation

sydb
Copy link
Member

@sydb sydb commented May 2, 2024

Added constraint to limit the use of attributes of the elementRef element per #2543.

Added constraint to limit use of attributes of the elementRef element
@sydb sydb added TEI: ODD CouncilResponsibility atop another TEI ODD processor labels May 2, 2024
@sydb sydb added this to the Guidelines 4.8.0 milestone May 2, 2024
@sydb sydb marked this pull request as draft May 2, 2024 12:31
fix error they found.
@sydb
Copy link
Member Author

sydb commented May 2, 2024

Added tests (in detest.odd), and lo and behold those tests caught an error! (I had forgotten the “tei:” prefix in one of the @test attributes.)
Fixed in bd1570a, at least it passed the tests on my system.

@sydb sydb marked this pull request as ready for review May 2, 2024 12:56
@ebeshero ebeshero merged commit 7685784 into dev Aug 13, 2024
2 checks passed
@ebeshero ebeshero deleted the sydb_2543_limit_attrs_on_elementRef branch August 13, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants