Feat: Video player v1 #703
Conversation
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WaDadidou
force-pushed
the
feat/video-player-v1
branch
from
e0060f4
to
b47cd78
Compare
|
|
||
| func (s *VideoService) GetVideoList(ctx context.Context, req *videopb.GetVideoListRequest) (*videopb.GetVideoListResponse, error) { | ||
| limit := req.GetLimit() | ||
| if limit <= 0 { |
There was a problem hiding this comment.
We should cap the limit to avoid to request too much of data
There was a problem hiding this comment.
Caped at 40
(Have to handle pagination ?)
| import { mustGetVideoClient } from "../../utils/backend"; | ||
| import { VideoMetaInfo, VideoInfoWithMeta } from "../../utils/types/video"; | ||
| import { useSelectedNetworkId } from "../useSelectedNetwork"; | ||
| export type VideosList = { |
There was a problem hiding this comment.
is that normal that we have definition of video list type or null ? it means that pages can be: array of null ? please check if we can implement differently or this is the only efficient way to do this.
There was a problem hiding this comment.
I ddin't check the videos hooks, will check later
| } as VideoInfoWithMeta); | ||
| }); | ||
|
|
||
| const totalCount = 1000; // test |
There was a problem hiding this comment.
is this normal we keep hardcoded test value there ?
There was a problem hiding this comment.
Need to handle pagination... Will do later
|
@WaDadidou are all files pushed? I'm getting some errors on files that it cannot find. |
WaDadidou
force-pushed
the
feat/video-player-v1
branch
from
198c96b
to
f50a949
Compare
WaDadidou
force-pushed
the
feat/video-player-v1
branch
6 times, most recently
from
6c455a3
to
7541035
Compare
WaDadidou
force-pushed
the
feat/video-player-v1
branch
3 times, most recently
from
c167742
to
7ce3a90
Compare
WaDadidou
force-pushed
the
feat/video-player-v1
branch
2 times, most recently
from
ed9ef6a
to
1cbe259
Compare
… from video-player indexer
WaDadidou
force-pushed
the
feat/video-player-v1
branch
from
942ed7a
to
f4e99c6
Compare
WaDadidou
force-pushed
the
feat/video-player-v1
branch
from
5883eaf
to
00bad8a
Compare
WaDadidou
force-pushed
the
feat/video-player-v1
branch
from
ae595d0
to
a5765a2
Compare
WaDadidou
force-pushed
the
feat/video-player-v1
branch
from
a5765a2
to
e9b9543
Compare
It's a Draft⚠️ So yes, it may be broken for now 😇
The original PR is #649. The feature frontend and backend were started by @Saturn-Radius. Thank you mate 😄
Need testnet backend to allow testing. We can only test on local env for now. -> See the original's PR https://github.com/TERITORI/teritori-dapp/pull/649description
TODO
I hope it's not a mess