Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FC05 addressing off-by-one #28

Closed
TG9541 opened this issue Apr 28, 2020 · 1 comment
Closed

FC05 addressing off-by-one #28

TG9541 opened this issue Apr 28, 2020 · 1 comment
Assignees
@TG9541
Labels
bug Something isn't working

Comments

@TG9541
Copy link
Owner

TG9541 commented Apr 28, 2020

I finally noticed that FC05 encodes the address of "Coil 173" with "AC (Hex)". This means that my musings in #19 are factually wrong. Easy enough to fix, we're still in "alpha".
@TG9541 TG9541 self-assigned this Apr 28, 2020
@TG9541 TG9541 added the bug Something isn't working label Apr 28, 2020
@TG9541
Copy link
Owner Author

TG9541 commented Apr 28, 2020

Also BF! has been applied - there is no limit to 8 "coils" any longer (I did a test with 64 coils).

@TG9541 TG9541 closed this as completed in 8c05dfe Apr 28, 2020
TG9541 added a commit that referenced this issue Apr 28, 2020
@TG9541
Merge pull request #29 from TG9541/C0135-fix-FC05
b9e1ebc 
fixes #28 FC05 addressing off-by-one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TG9541 TG9541

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TG9541