Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor version number #68

Closed
barewires opened this issue Sep 23, 2017 · 5 comments

Comments

@barewires
Copy link

commented Sep 23, 2017

May I suggest having the minor version number appended to the header:
stm8eForth v2.2.xx

@TG9541 TG9541 self-assigned this Sep 23, 2017
@TG9541

This comment has been minimized.

Copy link
Owner

commented Sep 23, 2017

The revision number should indeed be visible (the 2nd group of digits is usually called the minor).
But what should we do with development versions, and when should be increment the revision number?
Maybe we need to be more generous with the minor.
Any thoughts?

@TG9541 TG9541 added the question label Sep 23, 2017
@barewires

This comment has been minimized.

Copy link
Author

commented Sep 25, 2017

I suppose with all of the targets and devices that it could easily become unmanageable. Best if I put it in eeprom for my own records. Yes, a complex issue but worth thinking about. Thanks, no longer an issue.

@barewires

This comment has been minimized.

Copy link
Author

commented Sep 25, 2017

Just blasted the latest version 2.2.16 and as a major release can you reconsider adding .16
/home/pi/Downloads/2216/out/MINDEV/MINDEV.ihx

hi
stm8eForth v2.2.16

@TG9541

This comment has been minimized.

Copy link
Owner

commented Sep 26, 2017

I'll be looking into how to pass the revision number, and the release status, into the build chain.

@TG9541 TG9541 added enhancement and removed question labels Sep 26, 2017
@TG9541

This comment has been minimized.

Copy link
Owner

commented Oct 22, 2017

This issue will be resolved in #67: the revision number will be generated from a "package.json" file

@TG9541 TG9541 closed this Oct 22, 2017
TG9541 added a commit that referenced this issue Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.