Multiple error messages when using WP Theme Check #103

Closed
firstbasedesign opened this Issue Jul 10, 2012 · 2 comments

Projects

None yet

2 participants

@firstbasedesign

Hi,

Have noticed in either the latest version of TGM or Theme Check, that it throws countless errors! Older versions seemed to be ok?

This message mainly -

Possible variable $this found in translation function in functions/class-tgm-plugin-activation.php. Translation function calls must NOT contain PHP variables.

Any ideas? Obviously with submitting to ThemeForest I dont want the reviewers seeing this list of errors and having a fit!!

thanks

@thomasgriffin
Collaborator

Sorry about the late response on this. Somehow I missed it in my email inbox and just saw the notification here on Git.

That is because we use a variable, $theme_text_domain for localization instead of a string. To fix this, you would need to do a search and replace of all instances of the following in the script and replace it with either your own custom textdomain or 'tgmpa':

$this->domain
TGM_Plugin_Activation::$instance->domain

That will fix all of those warnings for you. I plan to address this in v3.0.0.

@firstbasedesign

How do I go about fixing these - TGM_Plugin_Activation::$instance->domain

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment